Make received parameter in VIA header compatible with url encoded IPv6 address #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will accept url encoded IPv6 addresses as the received parameter in the VIA header. Some sip server implementations tend to send the IPv6 address in url encoded (squared brackets) format altough this is not quite RFC compliat. However RFC5118 recommend to accept both IPv6 formats to make it compatible with all clients.
In this case we simply accept the
ipv6reference
as a validvia_address
. We need to make sure to return the ipv6 address without brackets tovia_received
, otherwise we will get some odd behaviour where LinePhone will increate the count of squared brackets(like: [[2001:db8::1]])
after each REGISTRATION request (we're not removing the brackets). To prevent this we will use the return value of ipv6reference and pass it to via_received. To make it compatible withipv4address
andipv6address
we will return their value invia_address
aswell.Fixes issue: BelledonneCommunications/linphone-desktop#332