Fix encoding of STUN ERROR-CODE attribute. #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encode_error_code is invoked with a reason, for example "Role Conflict", the reason ERROR-CODE attribute is encoded with incorrect padding (always 0 bytes of padding). The reason is that the padding calculation is done before the strlen() call to determine the reason length. This was discovered while investigating a FreeSwitch crash: https://freeswitch.org/jira/browse/FS-10394
|
A consequence of this issue is that role conflicts are never reported correctly to the remote party, so I suspect ICE is partially broken regardless of the UA on the other side. |
|
Thanks for discovering this issue and proposing a patch. This has been fixed in revision d74adb5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encode_error_code is invoked with a reason, for example
"Role Conflict", the reason ERROR-CODE attribute is encoded
with incorrect padding (always 0 bytes of padding).
The reason is that the padding calculation is done before the strlen()
call to determine the reason length.
This was discovered while investigating a FreeSwitch crash:
https://freeswitch.org/jira/browse/FS-10394