Fix camera size access. Allows for video on devices that don't have exact matching camera sizes. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid permission" This reverts commit 0b367d2.
|
-1 because it doesn't fix the actual problem. Camera 1 API will be deprecated in the near future |
| } | ||
| int camOrientation = characteristics.get(CameraCharacteristics.SENSOR_ORIENTATION); | ||
| StreamConfigurationMap configs = characteristics.get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP); | ||
| android.util.Size[] supportedSizes = configs.getOutputSizes(ImageFormat.JPEG); |
There was a problem hiding this comment.
Jpeg is not the only supported picture format. We should be able to get all the supported format here. https://developer.android.com/reference/android/hardware/camera2/params/StreamConfigurationMap.html#getOutputFormats()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.