setting things up for pypi #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnamcleod
reviewed
Mar 30, 2021
There was a problem hiding this comment.
- pyproject.toml - [build-system] currently points to poetry, is that fine for building a package for pip?
Yes, pip will ignore the pyproject.toml file.
- I'm not convinced we need all the libraries listed in
install_requiresinsetup.py- @johnamcleod you were taking care of dependencies before, can you give a hand here please?
True. I will look at that today and trim the list of dependencies.
|
@johnamcleod all good now? |
hstojic
added a commit
that referenced
this pull request
Apr 7, 2021
* Framework (#7) * Decision planning agents. (#8) * Background planning agents. (#9) * implemented coverage report with codecov.io (#11) * draft for codecov * added my PR branch * removing files spec * corrected an error in specifying file names * updated readme with badges and workflow badges * removed pypi installation instruction (#10) Co-authored-by: hstojic <hrvoje.stojic@protonmail.com> * Hstojic/trigger docs (#12) * modified publish-docs to trigger docs generation at website repo * tag example * accessing tag/branch environment variable * additional variable * removed testing branch * updating readme files - slack info, citaiton (#13) * setting things up for pypi (#14) * setting things up for pypi * isort; using main instead of version tags * corrected setup file; added MANIFEST file * updated readme file with pypi stuff * black * Remove redundant third party dependencies. (#15) * corrected workflows; small updates to the readme; corrected docs version * automatized release tag Co-authored-by: John Mcleod <43960404+johnamcleod@users.noreply.github.com> Co-authored-by: Felix Leibfried <felix.leibfried@gmail.com> Co-authored-by: Hrvoje Stojic <hrvoje.stojic@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 things I would need some help with:
install_requiresinsetup.py- @johnamcleod you were taking care of dependencies before, can you give a hand here please?I have set up a workflow for psuhing things to PyPi automatically, not sure how to test it though (hm, perhaps I could modfiy it to use test PyPi...)
I will first push things to test PyPi, to verify things work as intended