Remove redundant third party dependencies.

[johnamcleod]

No description provided.

[pvrancx]

assuming install still works - LGTM ;-)

[codecov-io]

Codecov Report

Merging #15 (927e4ed) into develop (2f3f736) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #15   +/-   ##
========================================
  Coverage    92.40%   92.40%           
========================================
  Files           66       66           
  Lines         1949     1949           
========================================
  Hits          1801     1801           
  Misses         148      148           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3f736...927e4ed. Read the comment docs.

[hstojic]

can we discuss first that removal of docs dependencies from development section of pyroject.toml file?

more discussion needed

[pvrancx]

can we discuss first that removal of docs dependencies from development section of pyroject.toml file?

I'm ok with docs having a separate build process, provided there is an automated command and it is documented.
I could see this being a part of the dev install, but don't feel strongly about this. TBH I tend not to build docs and just consult them online.

[johnamcleod]

can we discuss first that removal of docs dependencies from development section of pyroject.toml file?

I'm ok with docs having a separate build process, provided there is an automated command and it is documented.
I could see this being a part of the dev install, but don't feel strongly about this. TBH I tend not to build docs and just consult them online.

@hstojic is right - I had forgotten that there is a poetry command to build the docs, which at the moment does not install anything. There are three ways to address this:

1. update the command which builds the docs to install the extra requirements
2. Restore the dev dependencies for building the docs
3. Restore the previous action definition which explicitly installed the extra requirements

I would prefer the keep the dev dependencies and doc dependencies separate, so I would prefer 1) or 3), but I do not feel strongly about this.

[pvrancx]

• update the command which builds the docs to install the extra requirements
• Restore the dev dependencies for building the docs
• Restore the previous action definition which explicitly installed the extra requirements

So 1) would enable a separate poetry command that installs the dependencies and builds the docs? That would be my preference. I'd prefer to minimize the dependencies you are forced to install. Having a separate command gives maximum control to the user.

[hstojic]

not sure I understand what is 3)...

what about 4) where in dev part of dependencies we specify docs related packages as optional (same as for mujoco-py), for those contributors that might work on docs and will need/want to check whether it builds?

that would be better than 1) which would install packages every time I build docs (which might happen a lot when you are actively working on them)

depending on what we implement, we should update CONTRIBUTING.md, where it talks about building docs...

[johnamcleod]

what about 4) where in dev part of dependencies we specify docs related packages as optional (same as for mujoco-py), for those contributors that might work on docs and will need/want to check whether it builds?

That's good - I will go with that.

depending on what we implement, we should update CONTRIBUTING.md, where it talks about building docs...

Good point - I will also update this.

[hstojic]

4. doesn't seem to work, just tried it

it seems that optional flag cannot be used in dev-dependencies block: https://stackoverflow.com/questions/60971502/python-poetry-how-to-install-optional-dependencies#60990574

I think I would then go with 2), only contributors will be installing these few additional libs, and if they are using poetry then they are installing them into a virtual envirionment and there shouldnt be any issue with installing these few libs for the project...

[johnamcleod]

I have updated the contributors file to describe how to build the docs, and I have verified locally that the instructions work. The documentation build dependencies are listed in the docs_requirements.txt file, which can be installed separately from the dev dependencies to build the docs.

[pvrancx]

Looks fine to me - does this work for you @hstojic ?