boost(AutoUpdate): Keep the Update in a Temp folder with the real nam…

…e of the file. Let windows clean them up later. Fixes SOUNDSWITCH-5Y
Belphemur · Jun 26, 2022 · 59274db · 59274db
1 parent d4894a0
commit 59274db
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/SoundSwitch.Audio.Manager/AudioSwitcher.cs b/SoundSwitch.Audio.Manager/AudioSwitcher.cs
@@ -119,6 +119,11 @@ public void SwitchProcessTo(string deviceId, ERole role, EDataFlow flow, uint pr
                 Trace.TraceInformation($"Attempt to switch [{processId}] but got exception: {e}");
                 return;
             }
+            catch (ArgumentException e)
+            {
+                Trace.TraceInformation($"Attempt to switch [{processId}] but got exception: {e}");
+                return;
+            }
             catch (Exception e)
             {
                 Trace.TraceError($"Can't get process info: {e}");

diff --git a/SoundSwitch/Framework/Updater/AutoUpdater.cs b/SoundSwitch/Framework/Updater/AutoUpdater.cs
@@ -13,7 +13,6 @@
 ********************************************************************/
 
 using System;
-using System.IO;
 using System.Threading;
 using System.Windows.Forms;
 using Serilog;
@@ -30,23 +29,19 @@ public class AutoUpdater
     {
         private readonly SynchronizationContext _context = SynchronizationContext.Current ?? new SynchronizationContext();
         public string InstallerParameters { get; }
-        public string InstallerFilePath { get; }
-
         /// <summary>
         /// Constructor of the AutoUpdater
         /// </summary>
         /// <param name="installerParameters">Parameters given to the installer after downloading it</param>
-        /// <param name="filePath">Where to download the Installer without the filename</param>
-        public AutoUpdater(string installerParameters, string filePath)
+        public AutoUpdater(string installerParameters)
         {
             InstallerParameters = installerParameters;
-            InstallerFilePath = Path.Combine(filePath, "SoundSwitch_Update.exe");
         }
 
         public void Update(AppRelease appRelease, bool closeApp)
         {
 
-                var file = new WebFile(new Uri(appRelease.Asset.BrowserDownloadUrl), InstallerFilePath);
+                var file = new WebFile(new Uri(appRelease.Asset.BrowserDownloadUrl));
                 file.Downloaded += (sender, args) =>
                 {
                     Log.Information("Update downloaded: {File}", file);

diff --git a/SoundSwitch/Model/SoundSwitchApplicationContext.cs b/SoundSwitch/Model/SoundSwitchApplicationContext.cs
@@ -2,7 +2,6 @@
 using NAudio.CoreAudioApi;
 using Serilog;
 using SoundSwitch.Common.Framework.Audio.Device;
-using SoundSwitch.Framework;
 using SoundSwitch.Framework.Audio.Lister;
 using SoundSwitch.Framework.Banner;
 using SoundSwitch.Framework.Configuration;
@@ -31,7 +30,7 @@ public SoundSwitchApplicationContext()
             {
                 if (@event.UpdateMode == UpdateMode.Silent)
                 {
-                    new AutoUpdater("/VERYSILENT", ApplicationPath.Default).Update(
+                    new AutoUpdater("/VERYSILENT").Update(
                         @event.AppRelease, true);
                 }
             };