Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon on Left-Click menu for Capture devices not being set #1332

Closed
BigAal opened this issue Dec 19, 2023 · 5 comments
Closed

Icon on Left-Click menu for Capture devices not being set #1332

BigAal opened this issue Dec 19, 2023 · 5 comments
Labels
Bug Issues which are bug reports released

Comments

@BigAal
Copy link

BigAal commented Dec 19, 2023

What happened?

it is an easy fix, so in ProfileToolStripMenuItem, you set the icon to the Render device. If the Profile doesn't have a Render device, it just uses the unknown icon. You should check if device == null to check also for Capture Devices and take the icon of that one. Thanks.

Step to reproduce

explained above

Version

latest

What version of Windows are you seeing the problem on?

No response

Relevant log output

No response

@BigAal BigAal added the Bug Issues which are bug reports label Dec 19, 2023
@Belphemur
Copy link
Owner

Good catch and easy fix :)

However this will have to wait the next release, as I just released v6.8.0

@BigAal
Copy link
Author

BigAal commented Dec 19, 2023

oh no, I got lazy yesterday and just posted it. It's ok, I fixed it on my local ;)

@Belphemur
Copy link
Owner

Technically, you can just use the nightly if you prefer to not build it yourself :)

@BigAal
Copy link
Author

BigAal commented Dec 19, 2023

I did some other changes to cater for my stupid work laptop being so slow refreshing. I don't want to wait 8-12 seconds every time I use the USB switch, so I disabled refresh on device change, and added a manual refresh if I need to. Sloppy but working.

github-actions bot pushed a commit that referenced this issue Dec 24, 2023
## [6.8.1](v6.8.0...v6.8.1) (2023-12-24)

### Enhancements

* **installer:** add Korean language to the installer ([d30cdfd](d30cdfd))
* **profile::icon:** Check all device in profile for icon in systray menu ([f354698](f354698)), closes [#1332](#1332)
* **profile:** Order by alphabetical when showing profile in the systray menu ([58bec3f](58bec3f))

### Languages

* **Croatian:** Translated Settings using Weblate ([04bf70d](04bf70d))
* **Italian:** Translated Settings using Weblate ([d62ee5b](d62ee5b))
* **Portuguese:** Translated Settings using Weblate ([ce245db](ce245db))
* **Spanish:** Translated Settings using Weblate ([e156252](e156252))

### Bug Fixes

* **Startup:** Fix possible startup crash ([f841977](f841977)), closes [#1341](#1341)
github-actions bot pushed a commit that referenced this issue Dec 24, 2023
## [6.8.1](v6.8.0...v6.8.1) (2023-12-24)

### Enhancements

* **installer:** add Korean language to the installer ([d30cdfd](d30cdfd))
* **profile::icon:** Check all device in profile for icon in systray menu ([f354698](f354698)), closes [#1332](#1332)
* **profile:** Order by alphabetical when showing profile in the systray menu ([58bec3f](58bec3f))

### Languages

* **Croatian:** Translated Settings using Weblate ([04bf70d](04bf70d))
* **Italian:** Translated Settings using Weblate ([d62ee5b](d62ee5b))
* **Portuguese:** Translated Settings using Weblate ([ce245db](ce245db))
* **Spanish:** Translated Settings using Weblate ([e156252](e156252))

### Bug Fixes

* **Startup:** Fix possible startup crash ([f841977](f841977)), closes [#1341](#1341)
github-actions bot pushed a commit that referenced this issue Dec 24, 2023
## [6.8.1](v6.8.0...v6.8.1) (2023-12-24)

### Enhancements

* **installer:** add Korean language to the installer ([d30cdfd](d30cdfd))
* **profile::icon:** Check all device in profile for icon in systray menu ([f354698](f354698)), closes [#1332](#1332)
* **profile:** Order by alphabetical when showing profile in the systray menu ([58bec3f](58bec3f))

### Languages

* **Croatian:** Translated Settings using Weblate ([04bf70d](04bf70d))
* **Italian:** Translated Settings using Weblate ([d62ee5b](d62ee5b))
* **Portuguese:** Translated Settings using Weblate ([ce245db](ce245db))
* **Spanish:** Translated Settings using Weblate ([e156252](e156252))

### Bug Fixes

* **Startup:** Fix possible startup crash ([f841977](f841977)), closes [#1341](#1341)
Copy link
Contributor

🎉 This issue has been resolved in version 6.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues which are bug reports released
Projects
None yet
Development

No branches or pull requests

2 participants