Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dependency between 'Also switch default device' and 'Communication' in profile dialog #498

Closed
FireEmerald opened this issue Aug 27, 2020 · 3 comments
Assignees
Labels
Bug Issues which are bug reports Confirmed Confirmed issues

Comments

@FireEmerald
Copy link
Contributor

FireEmerald commented Aug 27, 2020

Describe the bug
If the user selects "Also switch default device" in profile without a device selected in "Communication" none error is shown.

Version
SoundSwitch v5.5.2

Expected behavior
A error message should be shown, as the Default device can't be switched without a actual selected one.
The dropdown should be only enabled if the checkbox is checked.

Screenshots
2020-08-27 08_47_28-Add Profile

Additional Context
Seems like this configuration does not lead to a crash but the user may wonder why his configuration does not work.

@FireEmerald FireEmerald added Bug Issues which are bug reports Confirmed Confirmed issues labels Aug 27, 2020
@Belphemur
Copy link
Owner

Belphemur commented Aug 27, 2020 via email

@FireEmerald
Copy link
Contributor Author

FireEmerald commented Aug 27, 2020

I assume you mean with "global device" = "Playback". (-> yep)

I got your point but I think it would be a waaay better to say if the user wants to switch the default device he must define it. The current solution is to much "magic" in the background. At the moment you assume that the user knows what you know: If there's nothing selected in Communication the Playback device is used.

In addition, the dropdown field can still be edited, although the corresponding checkbox is not active - that's horrible. The dropdown field does not have any effect if the checkbox is not checked.

Repository owner deleted a comment from Belphemur Aug 27, 2020
@FireEmerald FireEmerald changed the title Do not allow invalid profile configurations Show dependency between 'Also switch default device' and 'Communication' in profile dialog Aug 27, 2020
@Belphemur
Copy link
Owner

Belphemur commented Aug 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues which are bug reports Confirmed Confirmed issues
Projects
None yet
Development

No branches or pull requests

2 participants