Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish language added #244

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Spanish language added #244

merged 1 commit into from
Mar 9, 2018

Conversation

plextoriano
Copy link
Contributor

Hello,

I added the spanish resources for SoundSwitch. I hope this can expand the use in Spanish language users. Best Regards

@Belphemur
Copy link
Owner

Looks good to me, but I'll wait for @FireEmerald to chime in on this :)

FireEmerald
FireEmerald approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@FireEmerald FireEmerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. After this PR was merged, there are some minor things which must be edited so the user is able to select the language as well as the translated strings do fit inside the UI.

@Belphemur Belphemur merged commit 6ee362c into Belphemur:dev Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FireEmerald FireEmerald FireEmerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plextoriano @Belphemur @FireEmerald