fix(Array): Fix issue with array that have numerical property key

Fixes #571
Belphemur · Apr 9, 2023 · db7b5cb · db7b5cb
1 parent 958c421
commit db7b5cb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/lib/ArrayInfo.ts b/src/lib/ArrayInfo.ts
@@ -144,7 +144,7 @@ export class ArrayInfo {
 
   private getArrayDataAndIndexFromProperty(data: KeyValue): any {
     let indexToPull = 0
-    let tempData = data[this.property] ?? data
+    let tempData = data instanceof Array ? data : data[this.property] ?? data
     if (this.indicies.length > 0) {
       indexToPull = +this.indicies[this.indicies.length - 1]
       for (let i = 0; i < this.indicies.length - 1; i++) {

diff --git a/test/02-jsondb.test.ts b/test/02-jsondb.test.ts
@@ -470,6 +470,20 @@ describe('JsonDB', () => {
             }
         )
 
+        //issue #571
+        test(
+            'should have no issue with numerical property for getting data in an array',
+            async () => {
+                await db.push('/issue571/1[]', "Hello", true)
+                await db.push('/issue571/1[]', "world", true)
+                let data = await db.getObject("/issue571/1[0]");
+                expect(data).toBe("Hello");
+                data = await db.getObject("/issue571/1[-1]");
+                expect(data).toBe("world");
+
+            }
+        )
+
         test(
             'should throw an error when trying to append to a non array',
             async () => {