Add numeral system for vector change data #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support base 2~33 (base 34 has 'X' issue); add argument -r or --radix; control displayed widths
Ben1152000
reviewed
Aug 2, 2022
1. Add parameter in wiregroup to svg 2. Move mutation of wire[index] to value to svg and use value_type instead
|
Another issue is that conventionally binary numbers are represented with leading zeros to fill all the bits to disambiguate with 2's complement. However, decimal numbers are represented without leading zeros. Should numbers in other bases be represented with or without leading zeros? Currently, only decimal numbers are represented without leading zeros. |
I'd assume that for now we can treat the number as unsigned by default. It would be nice to be able to specify if a number is signed or unsigned though. |
Ben1152000
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support base 2~33 (base 34 has 'X' issue); add argument -r or --radix; control displayed widths