Add Extended VCD (EVCD) support #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In README.md: remove old arguments; add new arguments; add evcd
|
Some other detailed discussions see gtkwave/gtkwave#148 |
|
This PR partially resolves #13 |
Ben1152000
requested changes
Aug 31, 2022
fix: remove additional comments fix: add comments for each functions fix: add -o in example in README.md fix: give up `:=` operator as it's since Python 3.8 fix: evcd2vcd example in README.md
|
It seems that there is still a small bug when I use another example evcd file to test. Reviewing it. |
fix: reformat function comments feat: add a new evcd example generated by ModelSim fix: evcd2vcd allows multiple nested scopes/upscopes
|
Function comments reformatted |
Ben1152000
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended VCD is standardized by 1800-2017 IEEE Standard for SystemVerilog--Unified Hardware Design, Specification, and Verification Language. The EVCD2VCD converter referred to
gtkwave's implementation. However,gtkwave's implementation has some defects. For example, it cannot properly handle line feeds between one declaration. This issue has been resolved in this implementation. Besides,vcd_idsare stored in adictin a simple and pythonic way rather than Jim Plank's Red Black tree (JRB). Currently,vcdid_hashandvcdid_unhashare adopted fromgtkwave's implementation, but they may not be necessary, because they are originally designed to fit inJvaldata structure for more than 8-bit char or unsigned char array. Note that the function only provides basic syntax checking for EVCD file. A full and complete syntax checking is beyond Sootty's work.