Deletion of messages after banning the author is not being reflected

[hwanders]

When a user first gets banned and then their message gets deleted, the chat view does update accordingly: the deleted message persists.

Expected behavior

A deleted message should be removed from the chat view, even if its author has been banned before.

Additional info

According to @BenDMyers, first deleting the message (and then banning the user) works fine.
Observed during maxcellw's twitch stream.

[BenDMyers]

What makes this tricky is, from what I can tell, banning a commenter for their message within Twitch doesn't seem to fire the onMessageDeleted event (or maybe it does and there's an error somewhere?)

Anyways, if there's any way to delete the message when the user is banned, we should do so, as it breaks users' assumption that "deleting" the message will delete it in the overlay view, too.

[KenAKAFrosty]

I'll have to see what Comfy exposes to us but I'm fairly sure Twitch's API provides ban events (on mobile currently or I'd check for certain). If we listen for that event and then remove all messages with a matching sender, that should suffice, no?

[KenAKAFrosty]

Looked closer at Comfy. I have a hunch we could check onPart event for user metadata, since banning would force them to leave. There may be some sort of boolean flag on the user for 'banned' or similar? Then if so, delete all messages with a matching sender username

[BenDMyers]

I think this issue (still open, at time of writing) on the ComfyJS repo could be helpful: instafluff/ComfyJS#23 — it seems like the tmi.js client does expose a 'ban' event, but ComfyJS isn't yet consuming it.

I think maybe the best path forward for this issue could be contributing an onBan hook to ComfyJS that we could leverage here?

[KenAKAFrosty]

Perfect! I had half a mind to see if it was Comfy not exposing tmi functionality and here you've already dug into that very thing and even found a current issue! Id love to work with you to go contribute to Comfy (plus even if it takes time to get a PR merged, we could still use it in this codebase in the interim)

…

On Wed, Jan 12, 2022, 2:11 PM Ben Myers ***@***.***> wrote: I think this issue (still open, at time of writing) on the ComfyJS repo could be helpful: instafluff/ComfyJS#23 <instafluff/ComfyJS#23> — it seems like the tmi.js client does expose a 'ban' event, but ComfyJS isn't yet consuming it. I think maybe the best path forward for this issue could be contributing an onBan hook to ComfyJS that we could leverage here? — Reply to this email directly, view it on GitHub <#48 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVR4GZ2STO4IWBZV233CZALUVXG7XANCNFSM5LXTREKQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: <BenDMyers/showmy .***@***.***>

[BenDMyers]

@KenAKAFrosty Would you be able to look into adding the onBan hook upstream in ComfyJS?