lint: address more issues

backend/cli/src/persistence.rs

@@ -1,6 +1,6 @@
 use std::{
     env::current_dir,
-    fs::{create_dir, File},
+    fs::{create_dir_all, File},
     io::Write,
     path::PathBuf,
 };
@@ -16,7 +16,7 @@ impl SourceFileWriter {
         let mut directory = current_dir().unwrap();
         directory.push(Local::now().naive_local().to_string());
 
-        create_dir(&directory).unwrap();
+        create_dir_all(&directory).unwrap();
 
         Self { directory }
     }

backend/database/src/validators.rs

@@ -15,7 +15,7 @@ fn validate_hash(data: &str, expected_hash: Hash) -> bool {
 
 #[instrument]
 fn validate_domain(data: &str) -> bool {
-    data.split('.').count() > 1 && data.split('.').all(|section| !section.is_empty())
+    data.contains('.') && data.split('.').all(|section| !section.is_empty())
 }
 
 impl Indicator {

backend/server/src/routes/openapi.rs

@@ -245,10 +245,10 @@ impl Modify for SecurityAddon {
         );
         openapi.components = Some(components);
 
-        let scopes: [&str; 0] = [];
+        let scopes: Vec<String> = Vec::with_capacity(0);
         let data = vec![
-            SecurityRequirement::new("api_key", scopes),
-            SecurityRequirement::new("basic_auth", scopes),
+            SecurityRequirement::new("api_key", &scopes),
+            SecurityRequirement::new("basic_auth", &scopes),
         ];
         let unauthorized_response: RefOr<_> = ResponseBuilder::new()
             .description("Need to provide valid authentication")

frontend/src/api/ignoreLists.ts

@@ -32,7 +32,7 @@ export function ignoreListSlugQueryOptions(slug: string) {
   return queryOptions({
     queryKey: ["ignoreLists", "slugs", slug],
     queryFn: async ({ signal }) =>
-      fetcher.get<string>(`/ignoreLists/slugs/${slug}`, {
+      await fetcher.get<string>(`/ignoreLists/slugs/${slug}`, {
         signal,
       }),
   });

frontend/src/api/providers.ts

@@ -30,7 +30,7 @@ export function providerSlugQueryOptions(slug: string) {
   return queryOptions({
     queryKey: ["providers", "slugs", slug],
     queryFn: async ({ signal }) =>
-      fetcher.get<string>(`/providers/slugs/${slug}`, {
+      await fetcher.get<string>(`/providers/slugs/${slug}`, {
         signal,
       }),
   });
@@ -42,7 +42,7 @@ export function providerQueryOptions<T extends undefined | string>(
   return queryOptions({
     queryKey: ["providers", providerId],
     queryFn: async ({ signal }) => {
-      if (providerId == undefined) {
+      if (!providerId) {
         return null;
       }
 

frontend/src/api/sources.ts

@@ -32,7 +32,7 @@ export function sourceSlugQueryOptions(slug: string) {
   return queryOptions({
     queryKey: ["sources", "slugs", slug],
     queryFn: async ({ signal }) =>
-      fetcher.get<string>(`/sources/slugs/${slug}`, {
+      await fetcher.get<string>(`/sources/slugs/${slug}`, {
         signal,
       }),
   });

frontend/src/api/users.ts

@@ -25,7 +25,7 @@ export function userQueryOptions<T extends undefined | string>(userId: T) {
   return queryOptions({
     queryKey: ["users", userId],
     queryFn: async ({ signal }) => {
-      if (userId == undefined) {
+      if (!userId) {
         return null;
       }
 

frontend/src/components/api-tokens-table.tsx

@@ -216,7 +216,7 @@ const ApiTokensTable: React.FC<Props> = ({ apiTokens }) => {
                   <TableHead>
                     <Trans id="expires.at" />
                   </TableHead>
-                  <TableHead style={{ width: 110 }}></TableHead>
+                  <TableHead style={{ width: 110 }} />
                 </TableRow>
               </TableHeader>
               <TableBody className="text-xs">

frontend/src/components/empty.tsx

@@ -1,5 +1,5 @@
 import { cn } from "@/lib/utils";
-import { TransId } from "@/i18n";
+import { TransId, useTranslation } from "@/i18n";
 import { Trans } from "@/components";
 
 interface Props {
@@ -18,24 +18,30 @@ const Empty: React.FC<Props> = ({
   imageWidth = 500,
   extra,
   className,
-}) => (
-  <div
-    className={cn(
-      "flex flex-1 flex-col items-center justify-center gap-2 self-center justify-self-center p-4",
-      className,
-    )}
-  >
-    {image && <img src={image} width={imageWidth} />}
-    <div className="flex flex-col items-center text-center">
-      <h2 className="text-lg font-semibold">
-        <Trans id={title} />
-      </h2>
-      <p className="text-sm">
-        <Trans id={description} />
-      </p>
+}) => {
+  const { t } = useTranslation();
+
+  return (
+    <div
+      className={cn(
+        "flex flex-1 flex-col items-center justify-center gap-2 self-center justify-self-center p-4",
+        className,
+      )}
+    >
+      {image && (
+        <img src={image} alt={t("empty.image.alt")} width={imageWidth} />
+      )}
+      <div className="flex flex-col items-center text-center">
+        <h2 className="text-lg font-semibold">
+          <Trans id={title} />
+        </h2>
+        <p className="text-sm">
+          <Trans id={description} />
+        </p>
+      </div>
+      {extra}
     </div>
-    {extra}
-  </div>
-);
+  );
+};
 
 export default Empty;

frontend/src/components/error.tsx

@@ -41,6 +41,7 @@ const ErrorComponent: React.FC<Props> = ({ info, error }) => {
       <div className="hidden h-[20rem] w-[20rem] flex-col gap-6 lg:flex xl:h-[30rem] xl:w-[30rem]">
         <img
           src={Image}
+          alt={t("this.is.fine.image.alt")}
           className="h-fit w-fit rounded-xl border border-black object-cover text-white shadow-xl dark:border-border"
         />
 

frontend/src/components/forms/list-edit-create.tsx

@@ -480,7 +480,7 @@ const ListEditCreate: React.FC<Props> = ({
                           <TableHead>
                             <Trans id="kind" />
                           </TableHead>
-                          <TableHead style={{ width: 50 }}></TableHead>
+                          <TableHead style={{ width: 50 }} />
                         </TableRow>
                       </TableHeader>
                       <TableBody>

frontend/src/components/forms/provider-edit-create.tsx

@@ -367,7 +367,7 @@ const ProviderEditCreate: React.FC<Props> = ({
                       <div className="flex gap-2">
                         <img
                           src={field.value ?? undefined}
-                          alt={t("favicon")}
+                          alt={t("provider.favicon.alt")}
                           style={{ imageRendering: "pixelated" }}
                           className={cn(
                             "h-8 w-8 rounded border shadow",

frontend/src/components/forms/source-edit-create.tsx

@@ -496,7 +496,7 @@ const SourceEditCreate: React.FC<Props> = ({
                       <div className="flex gap-2">
                         <img
                           src={field.value ?? undefined}
-                          alt="favicon"
+                          alt={t("source.favicon.alt")}
                           style={{ imageRendering: "pixelated" }}
                           className={cn(
                             "h-8 w-8 rounded border shadow",

frontend/src/components/layouts/authenticated.tsx

@@ -142,7 +142,7 @@ export const Layout: React.FC = () => {
               },
             ]}
           />
-          {userHasAnyRoles(user!, ["request_create", "request_view"]) && (
+          {userHasAnyRoles(user, ["request_create", "request_view"]) && (
             <div className={cn("mx-4", isCollapsed && "mx-2")}>
               <Separator />
             </div>

frontend/src/components/layouts/authentication.tsx

@@ -3,11 +3,13 @@ import { TrainFrontTunnel } from "lucide-react";
 
 import { Layouts, Trans } from "@/components";
 import { getRandomBackground } from "@/assets";
+import { useTranslation } from "@/i18n";
 
 export const Authentication: React.FC<React.PropsWithChildren> = ({
   children,
 }) => {
   const bg = useMemo(() => getRandomBackground(), []);
+  const { t } = useTranslation();
 
   return (
     <div className="relative grid h-[800px] flex-col items-center justify-center lg:max-w-none lg:grid-cols-5 lg:ps-4">
@@ -16,11 +18,13 @@ export const Authentication: React.FC<React.PropsWithChildren> = ({
           <img
             id="lowres-login-img"
             src={bg.small}
+            alt={t("login.image.blurry.alt")}
             className="absolute h-full flex-1 object-cover blur-xl"
           />
           <img
             id="login-img"
             src={bg.big}
+            alt={t("login.image.alt")}
             className="absolute h-full flex-1 object-cover opacity-0 blur-xl transition duration-1000 ease-out"
             style={{ transitionProperty: "filter" }}
             onLoad={() => {

frontend/src/components/nav.tsx

@@ -59,7 +59,7 @@ const Nav: React.FC<NavProps> = ({ links, isCollapsed }) => {
   const user = useAtomValue(userAtom);
 
   const canViewAnyLinks = links.some(
-    (link) => !("roles" in link) || userHasRoles(user!, link.roles),
+    (link) => !("roles" in link) || userHasRoles(user, link.roles),
   );
 
   if (!canViewAnyLinks) {
@@ -74,7 +74,7 @@ const Nav: React.FC<NavProps> = ({ links, isCollapsed }) => {
       <nav className="grid gap-1 px-2 group-[[data-collapsed=true]]:justify-center group-[[data-collapsed=true]]:px-2">
         {links
           .filter(
-            (link) => !("roles" in link) || userHasRoles(user!, link.roles),
+            (link) => !("roles" in link) || userHasRoles(user, link.roles),
           )
           .map((link, index) =>
             isCollapsed ? (

frontend/src/components/raw-content.tsx

@@ -1,54 +1,31 @@
-import { useMemo } from "react";
-
 import CopyButton from "@/components/copy-button";
 import { cn } from "@/lib/utils";
 
 const RawContent: React.FC<{
   content?: string;
-  iframe?: boolean;
-  dangerouslyShowContent?: boolean;
   className?: string;
-}> = ({ content, iframe, dangerouslyShowContent, className }) => {
-  const cleanedContent = useMemo(() => {
-    return dangerouslyShowContent
-      ? content
-      : content
-          ?.replaceAll(/http/gi, "hxxp")
-          .replaceAll(/src="\/\//gi, 'src="hxxp://');
-  }, [content, dangerouslyShowContent]);
-
-  return (
-    <div
-      className={cn(
-        "dark:border-800 dark:bg-950 relative flex h-full w-full flex-1 overflow-hidden rounded border bg-muted shadow-md ring-white",
-        className,
-      )}
-    >
-      <div className="flex h-full max-h-[400px] min-h-[1.5rem] flex-1 text-xs dark:bg-black/50">
-        {iframe && (
-          <iframe
-            sandbox=""
-            srcDoc={cleanedContent}
-            className="h-[400px] w-full flex-1 dark:bg-white"
-          />
-        )}
-        {!iframe && (
-          <div
-            style={{
-              fontFamily:
-                'ui-monospace, SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace',
-            }}
-            className="flex h-full max-h-[400px] w-full flex-1 overflow-y-scroll whitespace-pre-wrap break-all p-3"
-          >
-            {cleanedContent}
-          </div>
-        )}
-        <div className="absolute bottom-2 right-2">
-          <CopyButton text={content} />
-        </div>
+}> = ({ content, className }) => (
+  <div
+    className={cn(
+      "dark:border-800 dark:bg-950 relative flex h-full w-full flex-1 overflow-hidden rounded border bg-muted shadow-md ring-white",
+      className,
+    )}
+  >
+    <div className="flex h-full max-h-[400px] min-h-[1.5rem] flex-1 text-xs dark:bg-black/50">
+      <div
+        style={{
+          fontFamily:
+            'ui-monospace, SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace',
+        }}
+        className="flex h-full max-h-[400px] w-full flex-1 overflow-y-scroll whitespace-pre-wrap break-all p-3"
+      >
+        {content}
+      </div>
+      <div className="absolute bottom-2 right-2">
+        <CopyButton text={content} />
       </div>
     </div>
-  );
-};
+  </div>
+);
 
 export default RawContent;

frontend/src/components/request-data-view.tsx

@@ -41,10 +41,16 @@ const RequestDataView: React.FC<Props> = ({ isFetching, data }) => {
 
       return [
         sourceWithoutErrors.sort((a, b) => {
-          const aDataLength =
-            a.data == undefined ? 0 : Array.isArray(a.data) ? a.data.length : 1;
-          const bDataLength =
-            b.data == undefined ? 0 : Array.isArray(b.data) ? b.data.length : 1;
+          const aDataLength = !a.data
+            ? 0
+            : Array.isArray(a.data)
+              ? a.data.length
+              : 1;
+          const bDataLength = !b.data
+            ? 0
+            : Array.isArray(b.data)
+              ? b.data.length
+              : 1;
 
           if (aDataLength > bDataLength) {
             return -1;

frontend/src/components/search-results/provider-search-result.tsx

@@ -8,11 +8,13 @@ import { Badge } from "@/components/ui/badge";
 import { ComponentSearchResultProps } from "@/components/generic-panel-search";
 import config from "@/lib/config";
 import { Trans } from "@/components";
+import { useTranslation } from "@/i18n";
 
 const ProviderSearchResult: React.FC<ComponentSearchResultProps<Provider>> = ({
   data: { slug, name, description, enabled, numSources, url, favicon },
 }) => {
   const [imgHasError, setImgHasError] = useState(false);
+  const { t } = useTranslation();
 
   return (
     <Link
@@ -30,6 +32,7 @@ const ProviderSearchResult: React.FC<ComponentSearchResultProps<Provider>> = ({
               src={
                 favicon ?? `${config.rest_server_base_url}/favicon?url=${url}`
               }
+              alt={t("provider.favicon.alt")}
               style={{ imageRendering: "pixelated" }}
               className={cn(
                 "h-6 w-6 rounded border shadow",

frontend/src/components/search-results/source-search-result.tsx

@@ -9,11 +9,13 @@ import { ComponentSearchResultProps } from "@/components/generic-panel-search";
 import config from "@/lib/config";
 import { sourceKindIconMapping } from "@/lib/data";
 import { Trans } from "@/components";
+import { useTranslation } from "@/i18n";
 
 const SourceSearchResult: React.FC<ComponentSearchResultProps<Source>> = ({
   data: { slug, name, description, enabled, providerId, url, favicon, kind },
 }) => {
   const [imgHasError, setImgHasError] = useState(true);
+  const { t } = useTranslation();
 
   const SourceKindIcon = sourceKindIconMapping[kind];
 
@@ -33,6 +35,7 @@ const SourceSearchResult: React.FC<ComponentSearchResultProps<Source>> = ({
               src={
                 favicon ?? `${config.rest_server_base_url}/favicon?url=${url}`
               }
+              alt={t("source.favicon.alt")}
               style={{ imageRendering: "pixelated" }}
               className={cn(
                 "hidden h-8 w-8 rounded border shadow",

frontend/src/components/secrets-table.tsx

@@ -144,7 +144,7 @@ const SecretsTable: React.FC<Props> = ({ secrets }) => {
                   >
                     <Trans id="sources" />
                   </TableHead>
-                  <TableHead style={{ width: 80 }}></TableHead>
+                  <TableHead style={{ width: 80 }} />
                 </TableRow>
               </TableHeader>
               <TableBody className="text-xs">