-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify to Pull Expected Points Summary and Pass Targets tables? #1
Comments
Hello, Hanzo. I am just now seeing your issue report! I am going to look into solving this issue now. Thank you for bringing it to my attention! Ben |
No problem -- is this one about the EP not matching the point differential
in some games? Check out the Colts 1999 season boxscores, that issue is
there for almost all the games.
…On Tue, May 16, 2017 at 4:17 PM, Ben Kite ***@***.***> wrote:
Hello, Hanzo. I am just now seeing your issue report! I am going to look
into solving this issue now. Thank you for bringing it to my attention!
Ben
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbE-1OqFgC8j-oseuF2KpcN9nVC6AQqnks5r6gRugaJpZM4NQrWs>
.
--
James Hanson
|
I have fixed the errors that were causing the script to fail on seasons from 2002 onward. For anything before that I still have work to do. Until I update things to work on all seasons on pro-football-reference.com, you can at least get 2002-2016. Before the season starts, I will update things to work in 2017. Teams changing cities (or expansion teams) make my process a lot more complicated. Thank you again for the issue report. I will leave this issue open until the code works on all seasons. |
Thanks, Ben -- I got confused and thought you were the guys from PFR (I
noticed they had some errors in their boxscores).
…On Wed, May 17, 2017 at 11:33 AM, Ben Kite ***@***.***> wrote:
I have fixed the errors that were causing the script to fail on seasons
from 2002 onward. For anything before that I still have work to do. Until I
update things to work on all seasons on pro-football-reference.com, you
can at least get 2002-2016. Before the season starts, I will update things
to work in 2017. Teams changing cities (or expansion teams) make my process
a lot more complicated.
Thank you again for the issue report. I will leave this issue open until
the code works on all seasons.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbE-1L7ffZPGhfOmyD9Zg8IpVcL-VzWVks5r6xNWgaJpZM4NQrWs>
.
--
James Hanson
|
I've never coded anything but have a love for advanced football analytics. I ran your play by play script and it worked great... but couldn't get it to pull other years without errors.
I'd love to pull the EP summaries and pass targets as well. Thanks in advance for any advice and help you can offer!
The text was updated successfully, but these errors were encountered: