Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to Pull Expected Points Summary and Pass Targets tables? #1

Open
HanzoTheRazor opened this issue May 4, 2017 · 4 comments
Open
Assignees

Comments

@HanzoTheRazor
Copy link

I've never coded anything but have a love for advanced football analytics. I ran your play by play script and it worked great... but couldn't get it to pull other years without errors.

I'd love to pull the EP summaries and pass targets as well. Thanks in advance for any advice and help you can offer!

@BenKite
Copy link
Owner

BenKite commented May 16, 2017

Hello, Hanzo. I am just now seeing your issue report! I am going to look into solving this issue now. Thank you for bringing it to my attention!

Ben

@BenKite BenKite self-assigned this May 16, 2017
@HanzoTheRazor
Copy link
Author

HanzoTheRazor commented May 16, 2017 via email

@BenKite
Copy link
Owner

BenKite commented May 17, 2017

I have fixed the errors that were causing the script to fail on seasons from 2002 onward. For anything before that I still have work to do. Until I update things to work on all seasons on pro-football-reference.com, you can at least get 2002-2016. Before the season starts, I will update things to work in 2017. Teams changing cities (or expansion teams) make my process a lot more complicated.

Thank you again for the issue report. I will leave this issue open until the code works on all seasons.

@HanzoTheRazor
Copy link
Author

HanzoTheRazor commented May 17, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants