Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts schema of patternProperties using the convertProperties method #1

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

enobrev
Copy link
Contributor

@enobrev enobrev commented Mar 5, 2020

The contents of patternProperties need to also be converted to json-schema, just like OpenApi properties would. This change calls SchemaConverter:convertProperties upon the results of SchemaConverter:convertPatternProperties to do so.

@BenMorel BenMorel mentioned this pull request Dec 9, 2020
@ctrl-f5
Copy link
Contributor

ctrl-f5 commented Dec 10, 2020

@BenMorel I approve this PR!

Also checked for compatibility with patternProperties support in the OAS, as they want to also add it, but it's not in the spec yet. But something to keep an eye on.

@BenMorel BenMorel merged commit d94d7f2 into BenMorel:master Dec 10, 2020
@BenMorel
Copy link
Owner

Thanks for your review, @ctrl-f5! 👍

@enobrev, sorry for merging so late. I was not into OpenAPI lately.

@BenMorel
Copy link
Owner

Released as 0.1.4.

@BenMorel
Copy link
Owner

Convert schema of patternProperties using the convertProperties method (#1).

If you want to suggest better release notes, please do so 😉

@enobrev
Copy link
Contributor Author

enobrev commented Dec 10, 2020

@BenMorel Works for me. Thanks @ctrl-f5 and @BenMorel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants