Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run housekeeping on GC collect #10

Merged
merged 17 commits into from Apr 1, 2024

Conversation

mvorisek
Copy link
Contributor

closes #9

@mvorisek
Copy link
Contributor Author

Hi @BenMorel, can this PR be merged and new release tagged?

Copy link
Owner

@BenMorel BenMorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, @mvorisek!

src/CycleWithDestructor.php Outdated Show resolved Hide resolved
src/WeakMap.php Outdated Show resolved Hide resolved
src/WeakMap.php Outdated Show resolved Hide resolved
tests/WeakMapTest.php Show resolved Hide resolved
src/WeakMap.php Outdated Show resolved Hide resolved
src/WeakMap.php Outdated Show resolved Hide resolved
Copy link
Owner

@BenMorel BenMorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this, LGTM @mvorisek! 👍

tests/WeakMapTest.php Show resolved Hide resolved
src/WeakMap.php Outdated Show resolved Hide resolved
src/WeakMap.php Outdated Show resolved Hide resolved
src/WeakMap.php Outdated Show resolved Hide resolved
@BenMorel BenMorel merged commit f44f1ca into BenMorel:master Apr 1, 2024
5 checks passed
@BenMorel
Copy link
Owner

BenMorel commented Apr 1, 2024

Thank you, @mvorisek!

@mvorisek mvorisek deleted the housekeeping_on_gc branch April 1, 2024 23:01
@BenMorel
Copy link
Owner

BenMorel commented Apr 2, 2024

Released as 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run housekeeping on GC cycle
2 participants