Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw correct errors for invalid keys #2

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

BackEndTea
Copy link
Contributor

Tests are based on the specificaitons.

@BenMorel BenMorel merged commit 7c5e964 into BenMorel:master Jan 22, 2020
@BenMorel
Copy link
Owner

Excellent, thank you!

Talking about specifications, it would be nice to be able to run the full test suite from php-src. I actually tried to parse the .phpt files and make a test class that runs them; but it failed because tests are full of var_dump(), which expose the internals of the polyfill and therefore don't look like the native WeakMap.

I guess that makes running them "as is" impossible, however I'd love if you could manually review all weakmap_*.phpt files, and ensure that every test out there is somehow covered in the polyfill's test suite!

@BackEndTea BackEndTea deleted the fix/type-error branch January 22, 2020 14:58
@BenMorel
Copy link
Owner

Released in 0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants