-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResideInNamespaceMatching with nested+internal types #98
Comments
NeVeSpl
added a commit
to NeVeSpl/NetArchTest
that referenced
this issue
Oct 10, 2021
Merged
I do not know what the author had in mind by restricting it only to private and public nested types, especially that in another place it is less restrictive:
I guess it is my mistake, since I am the one who wrote both methods :D . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi BenMorris,
we ran into a problem when trying to validate our nested internal types, which we first filtered for ResideInNamespaceMatching.
After examining the NetArchTest code, we found the extension method TypeDefinitionExtensions.GetNamespace, which only checks IsNestedPrivate or IsNestedPublic. For testing, we changed our class from internal to private and it worked.
The text was updated successfully, but these errors were encountered: