-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set property 'points' of undefined #2
Comments
Hi @JackVed! Congratulations, you discovered the first bug! 🎈Thanks for reporting 👍😃
Of course the code should run with an arbitrary number of parents so I will file a bug report in d3_dag. I will let you know as soon as there is a fix! Cheers, |
Hi @BenPortner! Could this be due to the same d3-dag bug? |
- improved node layout: constant separation in y-direction (d3-dag nodesize instead of size) - fixed bug #2: circular links not shown (keep track of inserted connections, more of a hack) - added helper function to find path (i.e. all nodes) between two nodes - toggle node visibility via d3 enter and exit - add transition to prevent tree jumping out of window for large expansions / collapses
Hi @JackVed, I just pushed some changes that should fix the second issue (link not showing up). Please note: I added a new required attribute to the I'm still working on the first issue, so please bear with me 😉 Cheers. |
(cherry picked from commit c291681b46036d524ac1d26b7c5d4974a1b9aaa6)
Hey @JackVed, the first bug should now be fixed as well! Try deleting the extra link and the tree should be displayed fine 👍 Thanks again for reporting the bug. js_family_tree is still in an early stage and there is a lot to do. Let me know if you encounter any other problems! Cheers. |
Hi @BenPortner Regarding the first bug, when I delete the extra link I encounter the error:
|
Hi @JackVed, I cannot reproduce your error (But found another bug on the way. Thanks 😉). Here is the data = {
"start":"id4",
"persons": {
"id2": {
"id": "id2",
"own_unions": ["u2"],
"parent_union": "u1",
"name": "item01",
"birthyear": 1900,
"deathyear": 1980,
},
"id1": {
"id": "id1",
"own_unions": ["u1"],
"name": "item00",
"birthyear": 1901,
"deathyear": 1985,
},
"id4": {
"id": "id4",
"own_unions": ["u4"],
"parent_union": "u3",
"name": "item02",
"birthyear": 1926,
"deathyear": 2009,
},
"id3": {
"id": "id3",
"own_unions": ["u3"],
"parent_union": "u2",
"name": "topic00",
"birthyear": 1902,
"deathyear": 1970,
},
"id6": {
"id": "id6",
"own_unions": [],
"parent_union": "u4",
"name": "item04",
"birthyear": 1931,
"deathyear": 2015,
},
"id5": {
"id": "id5",
"own_unions": ["u4"],
"parent_union": "u3",
"name": "item03",
"birthyear": 1930,
"deathyear": 2010,
},
},
"unions": {
"u1": {
"id": "u1",
"partner": ["id1"],
"children": ["id2"]
},
"u2": {
"id": "u2",
"partner": ["id2"],
"children": ["id3"]
},
"u3": {
"id": "u3",
"partner": ["id3"],
"children": ["id4", "id5"]
},
"u4": {
"id": "u4",
"partner": ["id4", "id5"],
"children": ["id6"]
},
},
"links": [
["id1", "u1"],
["u1", "id2"],
["id2", "u2"],
["u2", "id3"],
["id3", "u3"],
["u3", "id4"],
["u3", "id5"],
["id4", "u4"],
["id5", "u4"],
["u4", "id6"],
]
}; Can you confirm that the error persists if you clone the latest version of js_family_tree and overwrite the |
Closed due to inactivity. Feel free to re-open if problems persist! |
Hi @BenPortner,
I really like your work and I am trying to implement it!
I am using this data set:
But i encounter the error:
Why does this error happen?
Thanks in advance.
The text was updated successfully, but these errors were encountered: