Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.0 #203

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Support PHP 8.0 #203

merged 2 commits into from
Dec 15, 2020

Conversation

bepsvpt
Copy link
Contributor

@bepsvpt bepsvpt commented Dec 8, 2020

  • Added or updated tests
  • Added or updated the README.md
  • Detailed changes in the CHANGELOG.md unreleased section

Changes

This pull request let this package support PHP 8.0.

Because there is prefer-lowest testing matrix, to solve testing error, there are two new dependence requirements. (nikic/php-parser and mockery/mockery)

Without prefer-lowest testing matrix, these new dependencies are not required.

@bepsvpt
Copy link
Contributor Author

bepsvpt commented Dec 12, 2020

Hi @BenSampo,

Could you take a look for this pull request?

@HelloAlexPan
Copy link

Hey @BenSampo is there any update on this?

@stefro
Copy link

stefro commented Dec 15, 2020

Hi @BenSampo
Love this package! Can you please merge this PR?

@JonathanGuo
Copy link

It looks like this PR fixed the issue with prefer-lowest testing cases. Please take a look of the fix.

For now, I have to add --ignore-platform-reqs to force update the package.

@BenSampo BenSampo merged commit 210c5a8 into BenSampo:master Dec 15, 2020
@BenSampo
Copy link
Owner

Thanks @bepsvpt 👍

This was referenced Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants