This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
feat(tslint): use extends instead of rulesDirectory #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running `yarn install` updated the `yarn.lock` file
I misread the README and tried to use extends instead of rulesDirectory in `tslint.json` based on other tslint config packages I use (tslint-config-prettier, tslint-microsoft-contrib, tslint-react). This commit changes custom-tslint-rules' configuration to use rulesDirectory internally, which then allows the user to add "custom-tslint-rules" to the extends property in `tslint.json`. https://palantir.github.io/tslint/2016/03/31/sharable-configurations-rules.html https://github.com/palantir/tslint-react/blob/3.0.0/tslint-react.json#L2 https://github.com/alexjoverm/tslint-config-prettier#get-started https://github.com/Microsoft/tslint-microsoft-contrib/blob/b720cd9827a13c2878d304193544a5b030953ecb/tslint.json#L3 BREAKING CHANGE: this affects how users set up custom-tslint-rules, as they will need to change from rulesDirectory to extends in their own `tslint.json` confiigurations (as shown in the README), so I expect this to be a major breaking change (from 3.0.0 to 4.0.0).
|
Very interesting, I'll take a look and release if it makes sense. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misread the README and tried to use extends instead of rulesDirectory in
tslint.jsonbased on other TSLint config packages I use (tslint-config-prettier, tslint-microsoft-contrib, tslint-react). This commit changes custom-tslint-rules' configuration to use rulesDirectory internally, which then allows the user to add "custom-tslint-rules" to the extends property intslint.json.BREAKING CHANGE: this affects how users set up custom-tslint-rules, as they will need to change from rulesDirectory to extends in their own
tslint.jsonconfiigurations (as shown in the README), so I expect this to be a major breaking change (from 3.0.0 to 4.0.0).No pressure in terms of merging this change (since this was born out of me not clearly reading the directions 馃槼), but I did want to open this to share feedback on the extends/rulesDirectory confusion I had (since I expect to use extends after installing custom tslint rule packages). And thank you for the import-barrels rule, planning to try it out on my team! 馃檪