Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreListener change #164

Closed
AlfioRusso opened this issue Dec 14, 2018 · 4 comments
Closed

StoreListener change #164

AlfioRusso opened this issue Dec 14, 2018 · 4 comments

Comments

@AlfioRusso
Copy link
Contributor

AlfioRusso commented Dec 14, 2018

Problem

Right now StoreListeners do not have the capability to reason about diffs between old state and new state.
An example of usage could be change the LocalState of a ViewController in Tempura based on those differences inside func update(with state: V.VM.S) that could become func update(oldState: V.VM.S).

Proposal

Modify StoreListener to accept the oldState as parameter, this should be fairly simple.

┆Issue is synchronized with this Asana task by Unito

@LorDisturbia
Copy link
Contributor

Bump

@bolismauro
Copy link
Contributor

I think it is a good idea.
Do you have any idea on how to make this feature non-breaking?

@sync-by-unito
Copy link

sync-by-unito bot commented Jan 21, 2021

➤ Lorenzo D'Eri commented:

// Just a comment to trigger Unito

@danieleformichelli
Copy link
Contributor

Released in 6.0.0

jaredrobinson001 pushed a commit to jaredrobinson001/katana-swift that referenced this issue Sep 18, 2022
barba67 added a commit to barba67/katana-swift that referenced this issue Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants