🛠 [Fix] [TempuraTesting] Use correct screen size on orientation change #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: make screenSize of Context and VCContext optional
danieleformichelli
approved these changes
Apr 27, 2021
Comment on lines
69
to
+72
| func uiTest(testCases: [String], context: UITests.VCContext<VC>) { | ||
|
|
||
| // Set the orientation right away to retrieve the correct `UIScreen.main.bounds.size` later. | ||
| XCUIDevice.shared.orientation = context.orientation |
There was a problem hiding this comment.
[i]
Suggested change
| func uiTest(testCases: [String], context: UITests.VCContext<VC>) { | |
| // Set the orientation right away to retrieve the correct `UIScreen.main.bounds.size` later. | |
| XCUIDevice.shared.orientation = context.orientation | |
| func uiTest(testCases: [String], context: UITests.VCContext<VC>) { | |
| // Set the orientation right away to retrieve the correct `UIScreen.main.bounds.size` later. | |
| XCUIDevice.shared.orientation = context.orientation |
LorDisturbia
suggested changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Simple fix for #109 .
Changes
Use the correct
screenSize(if not already specified) by accessingUIScreen.main.bounds.sizeonly after have setXCUIDevice.shared.orientation.Note
This is a breaking change that makes
screenSizeofContextandVCContextoptional.Tasks