Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add Hydra 2.0.6 as explicit dependency #113

Merged
merged 7 commits into from
Apr 29, 2021
Merged

[Feat] Add Hydra 2.0.6 as explicit dependency #113

merged 7 commits into from
Apr 29, 2021

Conversation

LorDisturbia
Copy link
Contributor

@LorDisturbia LorDisturbia commented Apr 28, 2021 •
edited

Based on #111

Why
This ensures that:

  • Tempura uses a version of Hydra compatible with Swift 5.5+.
  • Tempura considers Hydra as an explicit dependency.

Changes
No API change

Tasks

  • Add relevant tests, if needed
  • Add documentation, if needed
  • Update README, if needed
  • Ensure that the demo project works properly

@LorDisturbia LorDisturbia mentioned this pull request Apr 28, 2021
Merged
4 tasks
@LorDisturbia LorDisturbia changed the base branch from release/tempura-7.0.0 to fix/xcode-12.5 April 28, 2021 12:55
@danieleformichelli danieleformichelli changed the base branch from fix/xcode-12.5 to release/tempura-7.0.0 April 29, 2021 11:42
@danieleformichelli danieleformichelli merged commit 323f540 into release/tempura-7.0.0 Apr 29, 2021
@danieleformichelli danieleformichelli deleted the feature/add-hydra-dependency branch April 29, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieleformichelli danieleformichelli danieleformichelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LorDisturbia @danieleformichelli