Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to set the file transfer size to 1MB on devices of type 30 #72

Closed
wants to merge 1 commit into from
Closed

Don't try to set the file transfer size to 1MB on devices of type 30 #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions heimdall/source/BridgeManager.cpp
View file
Open in desktop
Expand Up @@ -638,6 +638,9 @@ bool BridgeManager::BeginSession(void)

fileTransferSequenceMaxLength = 30;
fileTransferSequenceTimeout = 120000; // 2 minutes!
#if 0
// This may be correct for the SGH-I727, but it appears to not be correct
// for the SGH-T989.
fileTransferPacketSize = 1048576; // 1 MiB

FilePartSizePacket filePartSizePacket(fileTransferPacketSize); // 1 MiB
Expand All @@ -658,6 +661,7 @@ bool BridgeManager::BeginSession(void)
Interface::PrintError("Unexpected file part size response!\nExpected: 0\nReceived: %d\n", filePartSizeResponse.GetResult());
return (false);
}
#endif
}

return (true);
Expand Down