Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary ending comma when Share products list #2

Closed
Benjamin-Loison opened this issue Dec 5, 2023 · 1 comment
Closed

Unnecessary ending comma when Share products list #2

Benjamin-Loison opened this issue Dec 5, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Benjamin-Loison
Copy link
Owner

Benjamin-Loison commented Dec 5, 2023

https://github.com/openfoodfacts/smooth-app/blob/8b62ef84494fc1cfa312f7c754fd4b4396cee877/packages/smooth_app/lib/helpers/temp_product_list_share_helper.dart#L9
Benjamin-Loison/Signal-Android#3

Should verify building the app and testing the patch.

No interesting results in Issues and Pull requests for comma and shareProductList.

The only other occurrence of shareProductList (in addition to the text sharing), is opening in the web and https://world.openfoodfacts.org/products/3180940000326,3245415313155 works as good as https://world.openfoodfacts.org/products/3180940000326,3245415313155,.

void main() {
 print('Hello World!');
}
String shareProductList(List<String> barcodes) {
  /*final StringBuffer buffer = StringBuffer();

  for (final String i in barcodes) {
    buffer.write('$i,');
  }

  return buffer.toString();*/
  return barcodes.join(',');
}

void main() {
  List<String> barcodes = <String>['A', 'B'];
  //print('Hello, World!');
  String toPrint = shareProductList(barcodes);
  print(toPrint);
  print("test: $toPrint");
}
A,B
test: A,B

What

Steps to reproduce the behavior

  1. Go to '...'
  2. Click on '....'
  3. See error

Expected behavior

Why

Part of

Screenshot/Mockup/Before-After

Smartphone model

  • Device:
  • OS:
  • App Version:

Additional context

@Benjamin-Loison Benjamin-Loison added the bug Something isn't working label Dec 5, 2023
@Benjamin-Loison
Copy link
Owner Author

openfoodfacts#4887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant