Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serde_arrow_buffer:from_arrow/3 #17

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add serde_arrow_buffer:from_arrow/3 #17

wants to merge 1 commit into from

Conversation

Benjamin-Philip
Copy link
Owner

  • Add from_erlang/2 to serde_arrow_buffer
  • Add to_arrow/2
  • Add to_arrow docs
  • Add to_erlang/1
  • Store binary data as a single binary in a buffer
  • Add incomplete implementation of from_arrow

@Benjamin-Philip
Copy link
Owner Author

This PR will be rebased to main once main has the necessary features to full implement this function. Till then, this PR simply serves as a way to save any progress I have made with this function.

@Benjamin-Philip
Add incomplete implementation of from_arrow
600ed35 
This commits adds tests and an incomplete of from_arrow. Right now, it
can manage assigning a type, and length to the buffer, but is unable to
deserialize the actual data from arrow. This is because we also need a
validity bitmap to deserialize data, something which a buffer doesn't
have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Benjamin-Philip @josevalim