perf: Use hashset for fast comparison

BenjaminHalko · Dec 12, 2023 · 1fad904 · 1fad904
1 parent 7f26c5b
commit 1fad904
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/lib/ui/views/patches_selector/patches_selector_viewmodel.dart b/lib/ui/views/patches_selector/patches_selector_viewmodel.dart
@@ -25,6 +25,9 @@ class PatchesSelectorViewModel extends BaseViewModel {
       locator<PatcherViewModel>().selectedPatches;
   PatchedApplication? selectedApp = locator<PatcherViewModel>().selectedApp;
   String? patchesVersion = '';
+
+  Set<String> savedPatchNames = {};
+
   bool isDefaultPatchesRepo() {
     return _managerAPI.getPatchesRepo() == 'revanced/revanced-patches';
   }
@@ -48,6 +51,9 @@ class PatchesSelectorViewModel extends BaseViewModel {
     });
     currentSelection.clear();
     currentSelection.addAll(selectedPatches);
+
+    savedPatchNames = _managerAPI.getSavedPatches(selectedApp!.packageName).map((p) => p.name).toSet();
+
     notifyListeners();
   }
 
@@ -281,13 +287,10 @@ class PatchesSelectorViewModel extends BaseViewModel {
   }
 
   bool isPatchNew(Patch patch) {
-    final List<Patch> savedPatches =
-        _managerAPI.getSavedPatches(selectedApp!.packageName);
-    if (savedPatches.isEmpty) {
+    if (savedPatchNames.isEmpty) {
       return false;
     } else {
-      return !savedPatches
-          .any((p) => p.getSimpleName() == patch.getSimpleName());
+      return !savedPatchNames.contains(patch.name);
     }
   }