Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete course page #3

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Delete course page #3

merged 2 commits into from
Jun 16, 2022

Conversation

omarsalem7
Copy link
Collaborator

What does this PR do?

This PR is raised to add delete page

Description of the task to be completed

  • Add delete page for delete course
  • Add delete method using redux toolkit (Thunk)
  • Add route delete-course to delete page
  • Add loader component
  • Fix back and next buttons in home page to fixed in center of screen when scroll down in mobile menu.
  • Fix all linter errors.

How should it be tested

Clone the repository

git clone https://github.com/BenjaminSemah/capstone-front-end.git

Navigate to the folder

cd capstone-front-end

Checkout the branch

git checkout delete-course

Thanks for reviewing my PR 馃槉

@butlermuwo
Copy link
Collaborator

Hi @omarsalem7 馃槉,

STATUS: APPROVED! 馃 馃挴

giphy

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: 馃殌
Congratulations! 馃帀

Highlights

  • Descriptive pull request 鉁旓笍
  • Good descriptive readme 鉁旓笍
  • No linter errors 鉁旓笍

Cheers and Happy coding!馃憦馃憦馃憦

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Code Review by @butlermuwo

@omarsalem7 omarsalem7 merged commit b1574a7 into development Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants