Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en-GB]: missing object bytes for language en-GB #558

Closed
seedy opened this issue Jul 8, 2020 · 4 comments
Closed

[en-GB]: missing object bytes for language en-GB #558

seedy opened this issue Jul 8, 2020 · 4 comments

Comments

@seedy
Copy link

seedy commented Jul 8, 2020

I got error with partial stacktrace below:

TypeError: Cannot read property 'binarySuffixes' of undefined
    at formatting.js:204
    at formatting.js:202
    at p (formatting.js:93)
    at Object.format (formatting.js:815)
    at e.value (numbro.js:40)

When looking a bit deeper, I dug this out: languages[en-GB].bytes is undefined

Screenshot

@seedy
Copy link
Author

seedy commented Jul 8, 2020

ℹ️ I import and register language en-GB from numbro package:

import numbroEN from 'numbro/languages/en-GB';
...
numbro.registerLanguage(numbroEN);

@BenjaminVanRyseghem
Copy link
Owner

Thanks! Indeed, it appears that those where implemented only in french (language used by the contributor) and en-US (language used by the tests).

I will patch it so that there are default values for every languages.

@BenjaminVanRyseghem
Copy link
Owner

@all-contributors please add @seedy for bug

@allcontributors
Copy link
Contributor

@BenjaminVanRyseghem

I've put up a pull request to add @seedy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants