Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --report-unused-disable-directives option in eslint doesn't work with this plugin #111

Closed
edg2s opened this issue Jan 13, 2019 · 1 comment

Comments

@edg2s
Copy link

edg2s commented Jan 13, 2019

Description

If eslint is run with the --report-unused-disable-directives option, it incorrectly reports all inline directives inside HTML script tags

Setup configuration

  • ESLint version: 5.12.0
  • eslint-plugin-html version: 5.0.0
  • NodeJS version: 6
  • Operating System name and version: Ubuntu 18.04
  • ESLint configuration (.eslintrc): any

Aditional context

e.g.

<script>
  // eslint-disable-next-line no-eval
  eval( foo );
</script>

The no-eval directive is clearly required, but eslint --report-unused-disable-directives reports "Unused eslint-disable directive (no problems were reported from 'no-eval')".

The same code in a JS file report no such errors.

@BenoitZugmeyer
Copy link
Owner

Thank you for the report! Fixed in 5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants