Armor being destroyed with god mode enabled

[piotrskibapl]

Description
When the user gets in the water while he has god mode enabled, his armor durability is still affected. That would also happen when getting in the water on other players' islands - that should not happen as visitors are protected from damage by default.

Steps to reproduce the behavior:

1. Log in on the server
2. Wear an armor
3. Enable god mode
4. Jump into the water

Expected behavior
Your armor durability should remain unchanged, as you have god mode enabled.

Server Information:

• Database being used (Flat file, MySQL, Mongo): JSON
• OS: Linux
• Java Version: Java 8
• BentoBox version: 1.14.2
• Addons installed? AcidIsland, Challenges, ControlPanel, DimensionalTrees, Level, Limits, Warps

Additional context
The durability of armor is not affected when on a creative gamemode.

[tastybento]

What plugin are you using to enable God Mode? Unless there's an API, I'm not sure this will be possible to prevent.

[piotrskibapl]

I'm using God Mode from Essentials.
I see that it might not be possible to fix that easily, but what about preventing destroying armor by acid when visiting other player islands (without having god mode enabled - the visitors are protected from damage by default on islands of other players)?

[tastybento]

Essentials has an API. Please try the latest CI build (https://ci.bentobox.world) of AcidIsland and GodMode should protect you from acid and acid rain now.

[BONNe]

@tastybento
!!! where is dependency !!!
That is not how you add things!!!

[tastybento]

@BONNe e9656de

The CI server is having an issue building, but that's something else.

[tastybento]

AcidIsland is building on the CI server now. https://ci.codemc.io/job/BentoBoxWorld/job/AcidIsland/

[piotrskibapl]

I can confirm that it is working well on build 856, thanks!
However, my armor still gets destroyed from acid when visiting other islands (without god mode). Could that be potentially fixed too?

[tastybento]

It could be done. Is there a current problem with this? In AcidIsland, players can sail and visit other islands quite easily, so the general idea is that acid is a universal threat. Also, having acid magically stop could lead to exploits. For example, a player have visitors use the lack of acid to swim below an island and get into places they would not normally be able to get to, etc.

It could be done, but like I said, these things tend to have unintended consequences.

[piotrskibapl]

@tastybento correct me if I'm wrong, but by default the acid won't hurt you when you're not on your own island - so you are already able to have visitors use the lack of acid to swim below your island and get into places they would not normally be able to get to.
So, if you are visiting an island and the acid doesn't hurt you, then in my opinion your armor should not be damaged too. Or maybe it would be better to just enable the damage from acid for visitors?

[piotrskibapl]

Just checked and I'm not receiving any damage when swimming in the acid on an island that I'm not added to, while my armor still gets damaged.
Checked this on a newly created server running paper-385 and "Classic AcidIsland" package.

[tastybento]

Okay, let me look at this.

[tastybento]

Okay, this is done.