Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bskyblock-version-build and level-version-build #74

Closed
SlimeDog opened this issue Jul 27, 2019 · 4 comments
Closed

bskyblock-version-build and level-version-build #74

SlimeDog opened this issue Jul 27, 2019 · 4 comments
Assignees
Milestone

Comments

@SlimeDog
Copy link

Description

Is your feature request related to a problem?

n/a

Describe the solution you'd like us to implement.

Please add build number to the dev builds of BSkyBlock and Level, as you do for BentoBox and Challenges. For example, today:

  • bskyblock-1.6.0-SNAPSHOT-b390.jar

A consistent naming convention would be a bonus. (Challenges uses a different format from BentoBox.)

Describe alternatives you've considered.

At present, we have to add the build numbers to the file names ourselves (if we want to keep track at the filename level).

Additional context

n/a

@tastybento tastybento transferred this issue from BentoBoxWorld/BentoBox Aug 7, 2019
@tastybento tastybento self-assigned this Aug 7, 2019
@SlimeDog
Copy link
Author

SlimeDog commented Aug 7, 2019

Level build 246 produces level-1.6.0-SNAPSHOT.jar with no build number. And the file name is lowercase, unlike the other components (BSkyBlock just changed with the new build).

While I'm thinking about it: Challenges has a # instead of a b for the build indicator.

@tastybento
Copy link
Member

I haven't done Level yet. Reopening.

@tastybento tastybento reopened this Aug 7, 2019
@tastybento tastybento transferred this issue from BentoBoxWorld/BSkyBlock Aug 7, 2019
tastybento added a commit that referenced this issue Aug 7, 2019
#74

Also updates to latest PowerMockito and Mockito2
@tastybento tastybento added this to the 1.6.0 milestone Aug 7, 2019
@tastybento
Copy link
Member

Done!

@SlimeDog
Copy link
Author

SlimeDog commented Aug 7, 2019

Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants