Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly prevent BentoBox from loading Blueprint Bundles that have the same ID #1117

Closed
ghost opened this issue Jan 9, 2020 · 6 comments
Closed
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone

Comments

@ghost
Copy link

ghost commented Jan 9, 2020

unknown
unknown (1)

Version :
Running SPIGOT 1.14.4§2.
BentoBox version: 1.10.0
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, End
Loaded Addons:
Biomes 1.6.0.1 (ENABLED)
BSkyBlock 1.9.0 (ENABLED)
Challenges 0.8.0 §7(ENABLED)
Level 1.9.0 (ENABLED)

@johncsuti
Copy link
Contributor

Try /bsbadmin delete (username)

@tastybento
Copy link
Member

@AFGAME You have at least two blueprint bundles (JSON files) in your blueprint folder that have the same uniqueId in them. This can happen if you copy and paste the file but do not edit it.

To fix, look through the JSON files and make sure they have a unique uniqueId:

{
  "uniqueId": "default",

I recommend you use the admin GUI command (e.g., /bsb bp) to make new bundles instead of editing the file system.

@Poslovitch
Copy link
Member

I think we should catch the error and log it in a nicer way. And at the same time, only load the first encountered blueprint/bundle with that id.

@ghost
Copy link
Author

ghost commented Jan 10, 2020

I delete the one that launch in default to leave the one I want

@ghost
Copy link
Author

ghost commented Jan 10, 2020

My problem is resolve

@Poslovitch
Copy link
Member

Great. I will keep this issue opened so that I can add some code to prevent it from ever happening again.

@tastybento tastybento added the Type: Enhancement Improvement or modification which is usually a new feature. label Jan 10, 2020
@Poslovitch Poslovitch changed the title Is reset does not work Properly prevent BentoBox from loading Blueprint Bundles that have the same ID Jan 11, 2020
@Poslovitch Poslovitch self-assigned this Jan 11, 2020
@Poslovitch Poslovitch added the Status: In progress Working on the issue. label Jan 11, 2020
@Poslovitch Poslovitch added this to the 1.11.0 milestone Jan 11, 2020
@Poslovitch Poslovitch added Type: Bug and removed Type: Enhancement Improvement or modification which is usually a new feature. labels Jan 11, 2020
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants