Piston prevention dont work on 1.15.2

[Kryniowesegryderiusz]

Description

Describe the bug

Hi, its simple. Despite of disabled in settings, people can move blocks behind the range of the island by pistons.

Environment

BentoBox Version (Mandatory)

[00:31:31] [Render thread/INFO]: [CHAT] Running PAPER Niepoprawne.
[00:31:31] [Render thread/INFO]: [CHAT] BentoBox version: 1.8.0
[00:31:31] [Render thread/INFO]: [CHAT] Database: MYSQL
[00:31:31] [Render thread/INFO]: [CHAT] Loaded Game Worlds:
[00:31:31] [Render thread/INFO]: [CHAT] skyblock (SkyBlock): Overworld, Nether, End
[00:31:31] [Render thread/INFO]: [CHAT] Loaded Addons:
[00:31:31] [Render thread/INFO]: [CHAT] Biomes 1.6.0.2-SNAPSHOT-b141
[00:31:31] [Render thread/INFO]: [CHAT] BSkyBlock 1.9.0-SNAPSHOT-b511
[00:31:31] [Render thread/INFO]: [CHAT] CauldronWitchery 1.5.0.0-SNAPSHOT-#9
[00:31:31] [Render thread/INFO]: [CHAT] Challenges 0.9.0-SNAPSHOT-#381
[00:31:31] [Render thread/INFO]: [CHAT] DimensionalTrees 1.6.0-SNAPSHOT
[00:31:31] [Render thread/INFO]: [CHAT] Level 1.7.0-SNAPSHOT-b284
[00:31:31] [Render thread/INFO]: [CHAT] SkyblockCore 0.1
[00:31:31] [Render thread/INFO]: [CHAT] Warps 1.9.0

Plugins (Optional)

_______

Additional context (Optional)

[Poslovitch]

Please try updating BentoBox (and its addons) to a more recent version.

[NFRCG]

I'm having the same issue with the Piston Push flag on latest dev version of everything, as well. Can provide more info if needed. I set the "Piston Push" flag to disabled, and players are still able to use pistons on their island to push blocks past the border.

[05:48:15 INFO]: Running PAPER 1.15.2.
[05:48:15 INFO]: BentoBox version: 1.11.1-SNAPSHOT-b1632
[05:48:15 INFO]: Database: SQLITE
[05:48:15 INFO]: Loaded Game Worlds:
[05:48:15 INFO]: bskyblock_world (bskyblock): Overworld, [nether_color]Nether, [end_color]End
[05:48:15 INFO]: Loaded Addons:
[05:48:15 INFO]: Biomes 1.6.0.1-SNAPSHOT-b151 (ENABLED)
[05:48:15 INFO]: Border 1.0.3 (ENABLED)
[05:48:15 INFO]: BSkyBlock 1.11.1-SNAPSHOT-b590 (ENABLED)
[05:48:15 INFO]: Challenges 0.9.0-SNAPSHOT-b398 (ENABLED)
[05:48:15 INFO]: Level 1.9.3-SNAPSHOT-b342 (ENABLED)
[05:48:15 INFO]: Limits 1.9.2-SNAPSHOT-b200 (ENABLED)
[05:48:15 INFO]: TwerkingForTrees 1.1.2 (ENABLED)
[05:48:15 INFO]: Warps 1.9.3-SNAPSHOT-b222 (ENABLED)

[Poslovitch]

Okay, the behavior is reversed. "Disabled" means it allows pistons to push blocks outside islands. "Enabled" means it prevents them from doing so...

Now the question is: should we "fix" that bug at the risk of creating a "bug" for servers that already use that behavior?

[wellnesscookie]

Hmm, maybe you could change and fix a locale for it. So it generates a new one on update with a correction and a note?

[tastybento]

Here's the US English locale for Piston Push:

    PISTON_PUSH: 
      description: |-
          &a Allow pistons to push
          &a blocks outside island
      name: "Piston Push"

The default is that piston pushing is not allowed, so

• "Enabled" = Prevent piston pushing
• "Disabled" = Allow piston pushing

Clearly the text in the piston push description is wrong. One fix could be to change the text to say:

    PISTON_PUSH:
      name: "Piston Push Protection"
      description: |-
          &a Enable to prevent
          &a pistons from pushing
          &a blocks outside the island.

What do you think?

[Poslovitch]

Agreed.

[tastybento]

Translators should check the translations.