Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"commands.bentobox.reload.warning" is missing in en-US.yml #747

Closed
Poslovitch opened this issue Jun 10, 2019 · 3 comments
Closed

"commands.bentobox.reload.warning" is missing in en-US.yml #747

Poslovitch opened this issue Jun 10, 2019 · 3 comments
Assignees
Labels
Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. Type: Bug

Comments

@Poslovitch
Copy link
Member

Description

Describe the bug

1.5.0 added a "warning" message to /bentobox reload: commands.bentobox.reload.warning. This message, however, has not been added in the en-US locale and thus displays the reference.

Steps to reproduce the behavior

  1. Clean server setup with BentoBox 1.5.1.
  2. Type /bbox rl.

Screenshots and videos

None.

Expected behavior

The message should be included in the en-US locale, especially because this locale is expected to be always up to date.

Environment

Server

  • OS: Windows 10 64bits
  • Java version: 8u191

Plugins

BentoBox

BentoBox setup

BentoBox and Addons
Running SPIGOT 1.13.2.
BentoBox version: 1.5.1
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, End
Loaded Addons:
BSkyBlock 1.5.0 (ENABLED)
Configuration
  • Database: JSON

Additional context

None.

@Poslovitch Poslovitch added Type: Bug Status: Pending Waiting for a developer to start working on this issue. labels Jun 10, 2019
@Poslovitch Poslovitch added this to the 1.5.2 milestone Jun 10, 2019
@BONNe
Copy link
Member

BONNe commented Jun 10, 2019

Not only in en-US.
I think in all, as they all are based on this lang file.

@Poslovitch
Copy link
Member Author

Yeah, but once it's added in en-US, it can easily be reflected over all other locales.

@Poslovitch Poslovitch assigned Poslovitch and unassigned tastybento Jun 14, 2019
@Poslovitch Poslovitch added Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Jun 14, 2019
@Poslovitch
Copy link
Member Author

I think I'm just stupid.

warning: "&cWarning: Reloading may cause instability, so if you see errors afterwards, restart the server"

@Poslovitch Poslovitch added Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. and removed Status: In progress Working on the issue. labels Jun 14, 2019
@Poslovitch Poslovitch removed this from the 1.5.2 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants