Fix issue when Challenge and ChallengeLevel icons were stored with gl…

…owing effect and lore from admin panel. This issue happened because PanelItem overwrites ItemStack metaData. It is fixed by returning clone of icon element instead of returning actual icon.
BentoBoxWorld · Jan 23, 2019 · 38fce9a · 38fce9a
1 parent 9c4c5b7
commit 38fce9a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/world/bentobox/challenges/database/object/Challenge.java b/src/main/java/world/bentobox/challenges/database/object/Challenge.java
@@ -308,7 +308,7 @@ public List<String> getDescription()
      */
     public ItemStack getIcon()
     {
-        return icon;
+        return icon.clone();
     }
 
 

diff --git a/src/main/java/world/bentobox/challenges/database/object/ChallengeLevel.java b/src/main/java/world/bentobox/challenges/database/object/ChallengeLevel.java
@@ -138,7 +138,7 @@ public String getFriendlyName()
      */
     public ItemStack getIcon()
     {
-        return icon;
+        return icon.clone();
     }