Fix sonar cloud bugs

BentoBoxWorld · Mar 7, 2021 · 462c27f · 462c27f
1 parent c26b27a
commit 462c27f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/world/bentobox/challenges/ChallengesImportManager.java b/src/main/java/world/bentobox/challenges/ChallengesImportManager.java
@@ -241,7 +241,9 @@ public boolean generateDefaultChallengeFile(User user, World world, boolean over
                     this.addon.logWarning("challenges.messages.defaults-file-overwrite");
                 }
 
-                defaultFile.delete();
+                if (!defaultFile.delete()) {
+                    this.addon.logError("Could not delete file: " + defaultFile.getAbsolutePath());
+                }
             }
             else
             {

diff --git a/src/main/java/world/bentobox/challenges/ChallengesManager.java b/src/main/java/world/bentobox/challenges/ChallengesManager.java
@@ -262,7 +262,7 @@ private void loadChallenge(@NonNull Challenge challenge)
      * @param silent - if true, no messages are sent to user
      * @return - true if imported
      */
-    public boolean loadChallenge(@NonNull Challenge challenge,
+    public boolean loadChallenge(@Nullable Challenge challenge,
             boolean overwrite,
             User user,
             boolean silent)
@@ -346,7 +346,7 @@ private void loadLevel(@NonNull ChallengeLevel level)
      * @param silent of type boolean that indicate if message to user must be sent.
      * @return boolean that indicate about load status.
      */
-    public boolean loadLevel(@NonNull ChallengeLevel level,
+    public boolean loadLevel(@Nullable ChallengeLevel level,
             boolean overwrite,
             User user,
             boolean silent)