Skip to content

Commit

Permalink
Update Utils.java
Browse files Browse the repository at this point in the history
Avoid null-pointer issue if given item-list contains null elements.
The issue is still that list contains these elements.
  • Loading branch information
BONNe committed Aug 11, 2019
1 parent a50d00b commit dea7135
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/main/java/world/bentobox/challenges/utils/Utils.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static List<ItemStack> groupEqualItems(List<ItemStack> requiredItems)
// items are in players inventory.
for (ItemStack item : requiredItems)
{
boolean isUnique = true;
boolean isUnique = item != null;

int i = 0;
final int requiredSize = returnItems.size();
Expand All @@ -49,7 +49,7 @@ public static List<ItemStack> groupEqualItems(List<ItemStack> requiredItems)
i++;
}

if (isUnique)
if (isUnique && item != null)
{
// The same issue as in other places. Clone prevents from changing original item.
returnItems.add(item.clone());
Expand Down

0 comments on commit dea7135

Please sign in to comment.