Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI Editor Lose Functionality After Anvil Text Editing #132

Closed
Jerethkhan opened this issue Jun 14, 2019 · 2 comments
Closed

GUI Editor Lose Functionality After Anvil Text Editing #132

Jerethkhan opened this issue Jun 14, 2019 · 2 comments
Assignees
@BONNe
Labels
Type: Bug A bug in code.

Comments

@Jerethkhan
Copy link

When editing anything that uses the anvil UI to edit, finishing the edit and returning challenges GUI disables the menu functions. The menu simply acts as a chest allowing you to remove the items. This disrupts saving things (such as island level) as you can no longer click the save button.

Reproduce by using any editing tool (such as island level) then return to the Challenge Editor UI.

Server / BentoBox information:

Server: Paper 1.14.2 R-0.1
BentoBox: Version 1.5.1
BentoBox Plugins: Biomes 1.5.0.0, BSkyBlock 1.5.0, Challenges 0.7.5, Level 1.5.0, MagicCobblestoneGenerator 1.5.0.1

Screenshots / Server log

No output when the error occurs.
BONNe added a commit to BONNe/BentoBox that referenced this issue Jun 14, 2019
@BONNe
Fix Challenges GUI issue 132
2d7efa7 
BentoBoxWorld/Challenges#132
This issue happens because AnvilGUIClick event was processed after BentoBox registers new Panel. Lowering priority fix this issue.
BONNe added a commit to BONNe/BentoBox that referenced this issue Jun 14, 2019
@BONNe
Fix Challenges GUI issue 132
742ef90 
BentoBoxWorld/Challenges#132
This issue happens because AnvilGUIClick event was processed after BentoBox registers new Panel. 
I add extra check in InventoryClickEvent that not only checks if user has opened panel, but also compares if event and panel has the same inventory, before processing it as BentoBox Panel.
This was referenced Jun 14, 2019
Merged
Closed
@BONNe
Copy link
Member

BONNe commented Jun 14, 2019

@Poslovitch
This is BentoBox issue.
I add 2 PullRequests. Choose one:
#761 or #762

Poslovitch pushed a commit to BentoBoxWorld/BentoBox that referenced this issue Jun 14, 2019
@BONNe @Poslovitch
Secured the handling of InventoryClickEvent for panels (#761)
ebe2f5a 
* Fix Challenges GUI issue 132

Fixed BentoBoxWorld/Challenges#132
This issue happens because AnvilGUIClick event was processed after BentoBox registers new Panel. 
I add extra check in InventoryClickEvent that not only checks if user has opened panel, but also compares if event and panel has the same inventory, before processing it as BentoBox Panel.

* Removed the unneeded PlayerKickEvent
@BONNe
Copy link
Member

BONNe commented Jun 14, 2019 •
edited
Loading

This issue is fixed in BentoBox 1.5.2-SNAPSHOT-b1161.

@BONNe BONNe closed this as completed Jun 14, 2019
@BONNe BONNe added Type: Bug A bug in code. and removed Bug 💥 labels Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BONNe BONNe

Labels
Type: Bug A bug in code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BONNe @Jerethkhan