Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnowTracker lag #47

Closed
andris155 opened this issue Mar 21, 2020 · 5 comments
Closed

SnowTracker lag #47

andris155 opened this issue Mar 21, 2020 · 5 comments
Assignees
@tastybento
Labels
In progress this is being worked on under investigation this is being investigated

Comments

@andris155
Copy link
Contributor

Description

Describe the bug

SnowTracker listener cause server lag

Steps to reproduce the behavior

Use lot of Greenhouses the server.

Expected behavior

Screenshots and videos (Optional)

Capture

Environment

BentoBox Version (Mandatory)
[22:41:42 INFO]: Running PAPER 1.15.2.
[22:41:42 INFO]: BentoBox version: 1.12.0-SNAPSHOT-b1692
[22:41:42 INFO]: Database: JSON
[22:41:42 INFO]: Loaded Game Worlds:
[22:41:42 INFO]: acidisland_world (AcidIsland): Overworld, Nether, The End
[22:41:42 INFO]: Loaded Addons:
[22:41:42 INFO]: AcidIsland 1.11.3-SNAPSHOT-b688 (ENABLED)
[22:41:42 INFO]: Biomes 1.6.0.1-SNAPSHOT-b151 (ENABLED)
[22:41:42 INFO]: Challenges 0.9.0-SNAPSHOT-b400 (ENABLED)
[22:41:42 INFO]: Chat 1.0.4 (ENABLED)
[22:41:42 INFO]: DimensionalTrees 1.6.0-SNAPSHOT-b80 (ENABLED)
[22:41:42 INFO]: Greenhouses 1.0.1-SNAPSHOT-b213 (ENABLED)
[22:41:42 INFO]: Level 1.9.4-SNAPSHOT-b345 (ENABLED)
[22:41:42 INFO]: Likes 1.7.0-SNAPSHOT-b21 (ENABLED)
[22:41:42 INFO]: Warps 1.9.3-SNAPSHOT-b222 (ENABLED)

Plugins (Optional)

Plugins (86): AdminVedelem, AdvancedAchievements, antiRedstoneClock, AnvilRestrict, ArmorStandEditor, AsyncWorldEdit, BentoBox, BetterGUI, ChangeSkin, ChatControl, ChatReaction, ChestShop, ChestShopNotifier*, ChestSort, Citizens, CitizensCMD, CommandSigns, CompatNoCheatPlus, ConditionalCommands, CoreProtect, CraftBook, CratesPlus, CrazyAuctions, CrazyAuctionsLog, CustomCrafting, CustomOreGen, Duels, EnderContainers, EntityDetection, Ercgenerator, Essentials, EssentialsChat, EssentialsSpawn, EventekGUI, EventRendszer, HeadDatabase*, HolographicDisplays, JukeBox, Kemkedes, Kezdes, LockettePro, Lottery, LuckPerms, mcMMO, MineMarket-Universal*, MobFarmManager, Multiverse-Core, Multiverse-NetherPortals, MyCommand, MyPet, NametagEdit*, NoCheatPlus, NoteBlockAPI, OpenInv, PickupSpawners, PlaceholderAPI, PlugMan, PocketGames, ProtocolLib, RedstoneClockDetector, RemoveUnbreaking, RestrictedCreative, ShopGUIPlus, Shopkeepers, SignEdit, Sleepy*, StaffChat, StaffTime, SuperLuckyBlock, Szilveszter, TimeIsMoney*, TitleManager, TokenManager, TokenShopEditor, TokenStaff*, TreasureChest, Vault, Votifier, VotingPlugin, WDLCompanion*, WolfyUtilities, WorldEdit, WorldGuard, WorldGuardExtraFlags, WorldGuardPomaFlags, YoutubeBridge

Additional context (Optional)

[18:22:22] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - git-Paper-143 (MC: 1.15.2) ---
[18:22:22] [Paper Watchdog Thread/ERROR]: The server has not responded for 10 seconds! Creating thread dump
[18:22:22] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:22:22] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!):
[18:22:22] [Paper Watchdog Thread/ERROR]: Chunk wait task info below: 
[18:22:22] [Paper Watchdog Thread/ERROR]: 420,-359 in 'acidisland_world:
[18:22:22] [Paper Watchdog Thread/ERROR]: Load Task - none
[18:22:22] [Paper Watchdog Thread/ERROR]: Save Task - none
[18:22:22] [Paper Watchdog Thread/ERROR]: Chunk Holder - non-null
[18:22:22] [Paper Watchdog Thread/ERROR]: Chunk Status - minecraft:full
[18:22:22] [Paper Watchdog Thread/ERROR]: Chunk Holder Status - minecraft:features
[18:22:22] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:22:22] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread
[18:22:22] [Paper Watchdog Thread/ERROR]: 	PID: 32 | Suspended: false | Native: false | State: TIMED_WAITING
[18:22:22] [Paper Watchdog Thread/ERROR]: 	Stack:
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/jdk.internal.misc.Unsafe.park(Native Method)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.IAsyncTaskHandler.bl(IAsyncTaskHandler.java:131)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:120)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:396)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.World.getChunkAt(World.java:325)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.IWorldReader.getChunkAt(IWorldReader.java:87)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.World.getChunkAt(World.java:270)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.World.getType(World.java:649)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_15_R1.block.CraftBlock.getType(CraftBlock.java:208)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker.lambda$shakeGlobes$6(SnowTracker.java:122)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker$$Lambda$5034/0x0000000801b19040.test(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline.forEach(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker.shakeGlobes(SnowTracker.java:124)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker.lambda$startSnow$8(SnowTracker.java:129)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker$$Lambda$5675/0x0000000801c81840.run(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1185)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:430)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1112)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:934)
[18:22:22] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.lang.Thread.run(Unknown Source)
[18:22:22] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:22:22] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---
[18:22:22] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:22:25] [Async Chat Thread - #102/INFO]: [Tag]Sentinel02: Xddddd
[18:22:27] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - git-Paper-143 (MC: 1.15.2) ---
[18:22:27] [Paper Watchdog Thread/ERROR]: The server has not responded for 15 seconds! Creating thread dump
[18:22:27] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:22:27] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!):
[18:22:27] [Paper Watchdog Thread/ERROR]: Chunk wait task info below: 
[18:22:27] [Paper Watchdog Thread/ERROR]: 420,-359 in 'acidisland_world:
[18:22:27] [Paper Watchdog Thread/ERROR]: Load Task - none
[18:22:27] [Paper Watchdog Thread/ERROR]: Save Task - none
[18:22:27] [Paper Watchdog Thread/ERROR]: Chunk Holder - non-null
[18:22:27] [Paper Watchdog Thread/ERROR]: Chunk Status - minecraft:full
[18:22:27] [Paper Watchdog Thread/ERROR]: Chunk Holder Status - minecraft:features
[18:22:27] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:22:27] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread
[18:22:27] [Paper Watchdog Thread/ERROR]: 	PID: 32 | Suspended: false | Native: false | State: TIMED_WAITING
[18:22:27] [Paper Watchdog Thread/ERROR]: 	Stack:
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/jdk.internal.misc.Unsafe.park(Native Method)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.IAsyncTaskHandler.bl(IAsyncTaskHandler.java:131)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:120)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:396)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.World.getChunkAt(World.java:325)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.IWorldReader.getChunkAt(IWorldReader.java:87)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.World.getChunkAt(World.java:270)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.World.getType(World.java:649)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_15_R1.block.CraftBlock.getType(CraftBlock.java:208)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker.lambda$shakeGlobes$6(SnowTracker.java:122)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker$$Lambda$5034/0x0000000801b19040.test(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.util.stream.ReferencePipeline.forEach(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker.shakeGlobes(SnowTracker.java:124)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker.lambda$startSnow$8(SnowTracker.java:129)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		world.bentobox.greenhouses.listeners.SnowTracker$$Lambda$5675/0x0000000801c81840.run(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1185)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:430)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1112)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:934)
[18:22:27] [Paper Watchdog Thread/ERROR]: 		java.base@11.0.6/java.lang.Thread.run(Unknown Source)
[18:22:27] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:22:27] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---

https://timings.aikar.co/?id=cf4f93a91653498085adadd3df366338
@tastybento tastybento self-assigned this Mar 22, 2020
@tastybento tastybento added In progress this is being worked on under investigation this is being investigated labels Mar 22, 2020
tastybento added a commit that referenced this issue Mar 22, 2020
@tastybento
Only track snow for loaded greenhouses.
51d82d0 
Load chunks async.

#47
@tastybento
Copy link
Member

Please try the latest CI build and see if it helps:
https://ci.codemc.io/job/BentoBoxWorld/job/Greenhouses/

@andris155
Copy link
Contributor Author

This not fixed. :(
Capture
https://timings.aikar.co/?id=031dc66fb93940c5a25e01dfc94e80c7

@tastybento
Copy link
Member

I looked at the link to the timings you gave and I cannot see any reference to SnowTracker in it. It doesn't match your screenshot. Can you double check?

@Poslovitch
Copy link
Member

@tastybento You need to "move" the time frame of the timings. By default, TimingsV2 only show the timings from the first 3 dots. That's on the upper side of the page.

@tastybento
Copy link
Member

09308420-5D36-434D-9D77-9BA287A9687B

I scaled out to include all the timings. This looks pretty good to me for this task.

I am seeing a lot of entity lag. In the latest AcidIsland snapshot there are config options to set entity limits. That should also help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
In progress this is being worked on under investigation this is being investigated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tastybento @andris155 @Poslovitch