Fixes tests and adds new tests for MainGeneratorListener

BentoBoxWorld · Mar 2, 2020 · 892cd5e · 892cd5e
1 parent 6d64e66
commit 892cd5e
Show file tree

Hide file tree

Showing 2 changed files with 128 additions and 11 deletions.
diff --git a/src/main/java/world/bentobox/magiccobblestonegenerator/listeners/MainGeneratorListener.java b/src/main/java/world/bentobox/magiccobblestonegenerator/listeners/MainGeneratorListener.java
@@ -1,7 +1,15 @@
 package world.bentobox.magiccobblestonegenerator.listeners;
 
 
-import org.bukkit.*;
+import java.util.Collection;
+import java.util.Optional;
+import java.util.Random;
+
+import org.bukkit.Bukkit;
+import org.bukkit.Material;
+import org.bukkit.Particle;
+import org.bukkit.Sound;
+import org.bukkit.SoundCategory;
 import org.bukkit.block.Block;
 import org.bukkit.block.BlockFace;
 import org.bukkit.entity.Entity;
@@ -10,13 +18,10 @@
 import org.bukkit.event.EventPriority;
 import org.bukkit.event.Listener;
 import org.bukkit.event.block.BlockFromToEvent;
+
 import world.bentobox.bentobox.database.objects.Island;
 import world.bentobox.magiccobblestonegenerator.StoneGeneratorAddon;
 
-import java.util.Collection;
-import java.util.Optional;
-import java.util.Random;
-
 
 /**
  * Main Generator Listener. This class contains listener that process Generator options.
@@ -411,7 +416,7 @@ private boolean isFlowingLavaBlock(Block block) {
      * @param block Block that must be checked.
      * @return true if there is a player in the set range
      */
-    private boolean isInRangeToGenerate(Block block) {
+    protected boolean isInRangeToGenerate(Block block) {
         int workingRange = this.addon.getSettings().getWorkingRange();
         if (workingRange > 0) {
             boolean result = false;

diff --git a/...st/java/world/bentobox/magiccobblestonegenerator/listeners/MainGeneratorListenerTest.java b/...st/java/world/bentobox/magiccobblestonegenerator/listeners/MainGeneratorListenerTest.java
@@ -1,36 +1,50 @@
 package world.bentobox.magiccobblestonegenerator.listeners;
 
-import static org.junit.Assert.*;
-import static org.mockito.ArgumentMatchers.*;
-import static org.mockito.Mockito.*;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyBoolean;
+import static org.mockito.ArgumentMatchers.anyDouble;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.Optional;
+import java.util.UUID;
 
 import org.bukkit.Bukkit;
 import org.bukkit.Location;
 import org.bukkit.Material;
 import org.bukkit.World;
 import org.bukkit.block.Block;
+import org.bukkit.entity.Entity;
+import org.bukkit.entity.Player;
 import org.bukkit.event.block.BlockFromToEvent;
 import org.bukkit.scheduler.BukkitScheduler;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
+import org.mockito.Mockito;
 import org.powermock.api.mockito.PowerMockito;
 import org.powermock.core.classloader.annotations.PrepareForTest;
 import org.powermock.modules.junit4.PowerMockRunner;
 import org.powermock.reflect.Whitebox;
 
+import com.google.common.collect.ImmutableSet;
+
 import world.bentobox.bentobox.BentoBox;
 import world.bentobox.bentobox.api.flags.Flag;
 import world.bentobox.bentobox.database.objects.Island;
 import world.bentobox.bentobox.managers.IslandsManager;
 import world.bentobox.magiccobblestonegenerator.StoneGeneratorAddon;
 import world.bentobox.magiccobblestonegenerator.StoneGeneratorManager;
+import world.bentobox.magiccobblestonegenerator.config.Settings;
 import world.bentobox.magiccobblestonegenerator.tasks.MagicGenerator;
 
-import java.util.Optional;
-
 /**
  * @author tastybento
  *
@@ -70,6 +84,8 @@ public class MainGeneratorListenerTest {
     private Island island;
     @Mock
     private Flag flag;
+    @Mock
+    private Settings settings;
 
     /**
      * @throws java.lang.Exception
@@ -78,12 +94,18 @@ public class MainGeneratorListenerTest {
     public void setUp() throws Exception {
         // Set up plugin
         Whitebox.setInternalState(BentoBox.class, "instance", plugin);
+
+        // Addon
         when(addon.getPlugin()).thenReturn(plugin);
         when(addon.getFlag()).thenReturn(flag);
         when(flag.isSetForWorld(any())).thenReturn(true);
         when(addon.getIslands()).thenReturn(im);
         when(im.getIslandAt(any())).thenReturn(Optional.of(island));
         when(island.isAllowed(any())).thenReturn(true);
+
+        // Settings
+        when(settings.getWorkingRange()).thenReturn(0); // Default to 0
+        when(addon.getSettings()).thenReturn(settings);
 
         // Bukkit
         PowerMockito.mockStatic(Bukkit.class);
@@ -279,5 +301,95 @@ public void testOnBlockFromToEventLava2AirAboveAir() {
         verify(scheduler, never()).runTask(eq(plugin), any(Runnable.class));
     }
 
+    /**
+     * Test method for {@link world.bentobox.magiccobblestonegenerator.listeners.MainGeneratorListener#isInRangeToGenerate(Block)}.
+     */
+    @Test
+    public void testInRange() {
+        when(settings.getWorkingRange()).thenReturn(0);
+        assertTrue(mgl.isInRangeToGenerate(block));
+    }
+
+    /**
+     * Test method for {@link world.bentobox.magiccobblestonegenerator.listeners.MainGeneratorListener#isInRangeToGenerate(Block)}.
+     */
+    @Test
+    public void testInRangeWithValueNoIsland() {
+        when(settings.getWorkingRange()).thenReturn(10);
+        when(im.getIslandAt(any())).thenReturn(Optional.empty());
+        assertFalse(mgl.isInRangeToGenerate(block));
+    }
+
+    /**
+     * Test method for {@link world.bentobox.magiccobblestonegenerator.listeners.MainGeneratorListener#isInRangeToGenerate(Block)}.
+     */
+    @Test
+    public void testInRangeWithValueIslandNoEntities() {
+        when(settings.getWorkingRange()).thenReturn(10);
+        when(world.getNearbyEntities(any(Location.class), anyDouble(), anyDouble(), anyDouble())).thenReturn(Collections.emptyList());
+        assertFalse(mgl.isInRangeToGenerate(block));
+    }
+
+    /**
+     * Test method for {@link world.bentobox.magiccobblestonegenerator.listeners.MainGeneratorListener#isInRangeToGenerate(Block)}.
+     */
+    @Test
+    public void testInRangeWithValueIslanEntitiesMobsOnly() {
+        when(settings.getWorkingRange()).thenReturn(10);
+        Entity entity = Mockito.mock(Entity.class);
+        when(world.getNearbyEntities(any(Location.class), anyDouble(), anyDouble(), anyDouble())).thenReturn(Collections.singletonList(entity));
+        assertFalse(mgl.isInRangeToGenerate(block));
+    }
+
+    /**
+     * Test method for {@link world.bentobox.magiccobblestonegenerator.listeners.MainGeneratorListener#isInRangeToGenerate(Block)}.
+     */
+    @Test
+    public void testInRangeWithValueIslanEntitiesPlayerInTeamInRange() {
+        when(settings.getWorkingRange()).thenReturn(10);
+        Player entity = Mockito.mock(Player.class);
+        UUID uuid = UUID.randomUUID();
+        when(entity.getUniqueId()).thenReturn(uuid);
+        when(entity.getLocation()).thenReturn(location);
+        ImmutableSet<UUID> imSet = ImmutableSet.of(uuid);
+        when(island.getMemberSet()).thenReturn(imSet);
+        when(world.getNearbyEntities(any(Location.class), anyDouble(), anyDouble(), anyDouble())).thenReturn(Collections.singletonList(entity));
+        assertTrue(mgl.isInRangeToGenerate(block));
+    }
+
+    /**
+     * Test method for {@link world.bentobox.magiccobblestonegenerator.listeners.MainGeneratorListener#isInRangeToGenerate(Block)}.
+     */
+    @Test
+    public void testInRangeWithValueIslanEntitiesPlayerNotInTeamInRange() {
+        when(settings.getWorkingRange()).thenReturn(10);
+        Player entity = Mockito.mock(Player.class);
+        UUID uuid = UUID.randomUUID();
+        when(entity.getUniqueId()).thenReturn(uuid);
+        when(entity.getLocation()).thenReturn(location);
+        ImmutableSet<UUID> imSet = ImmutableSet.of(UUID.randomUUID()); // Not UUID
+        when(island.getMemberSet()).thenReturn(imSet);
+        when(world.getNearbyEntities(any(Location.class), anyDouble(), anyDouble(), anyDouble())).thenReturn(Collections.singletonList(entity));
+        assertFalse(mgl.isInRangeToGenerate(block));
+    }
+
+    /**
+     * Test method for {@link world.bentobox.magiccobblestonegenerator.listeners.MainGeneratorListener#isInRangeToGenerate(Block)}.
+     */
+    @Test
+    public void testInRangeWithValueIslanEntitiesPlayerInTeamNotInRange() {
+        int range = 10;
+        when(settings.getWorkingRange()).thenReturn(range);
+        Player entity = Mockito.mock(Player.class);
+        UUID uuid = UUID.randomUUID();
+        when(entity.getUniqueId()).thenReturn(uuid);
+        when(entity.getLocation()).thenReturn(location);
+        ImmutableSet<UUID> imSet = ImmutableSet.of(uuid);
+        when(island.getMemberSet()).thenReturn(imSet);
+        when(world.getNearbyEntities(any(Location.class), anyDouble(), anyDouble(), anyDouble())).thenReturn(Collections.singletonList(entity));
+        // Distance
+        when(location.distance(any())).thenReturn(range + 1D);
+        assertFalse(mgl.isInRangeToGenerate(block));
+    }
 
 }