Sign Cache could get out of sync with signs.

#80
BentoBoxWorld · May 27, 2020 · 94f0ff4 · 94f0ff4
1 parent 74675ab
commit 94f0ff4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/main/java/world/bentobox/warps/SignCacheManager.java b/src/main/java/world/bentobox/warps/SignCacheManager.java
@@ -72,8 +72,9 @@ List<String> getSign(World world, UUID playerUUID) {
      * @param key - uuid of owner
      */
     void removeWarp(World world, UUID key) {
-        cachedSigns.putIfAbsent(world, new HashMap<>());
-        cachedSigns.get(world).remove(key);
+        if (cachedSigns.containsKey(world)) {
+            cachedSigns.get(world).remove(key);
+        }
     }
 
 }
diff --git a/src/main/java/world/bentobox/warps/WarpSignsManager.java b/src/main/java/world/bentobox/warps/WarpSignsManager.java
@@ -245,17 +245,19 @@ public void removeWarp(World world, UUID uuid) {
         if (getWarpMap(world).containsKey(uuid)) {
             popSign(getWarpMap(world).get(uuid));
             getWarpMap(world).remove(uuid);
-            // Remove sign from warp panel cache
-            addon.getWarpPanelManager().removeWarp(world, uuid);
+
         }
+        // Remove sign from warp panel cache
+        addon.getWarpPanelManager().removeWarp(world, uuid);
         saveWarpList();
     }
 
     /**
      * Saves the warp lists to the database
      */
     public void saveWarpList() {
-        handler.saveObject(warpsData .save(worldsWarpList));
+        handler.saveObject(warpsData.save(worldsWarpList));
+        addon.getWarpPanelManager().saveCache();
     }
 
     /**