Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think that there are some typo in the code #189

Open
nasy960 opened this issue Oct 1, 2023 · 4 comments · May be fixed by #193
Open

I think that there are some typo in the code #189

nasy960 opened this issue Oct 1, 2023 · 4 comments · May be fixed by #193
Assignees
Labels
type: bug Something isn't working

Comments

@nasy960
Copy link

nasy960 commented Oct 1, 2023

I think there should be "curve_elem" instead of "cubic_elem".

Is that right?

@nasy960
Copy link
Author

nasy960 commented Oct 1, 2023

Before I change that, NameError: name 'cubic_elem' is not defined occured.
But, after I change that part, it doesn't occured.

@Eric-Vin
Copy link
Collaborator

Eric-Vin commented Oct 3, 2023

Thanks for the report! This is a definitely a bug and we'll patch it. Unfortunately it wasn't detected by our test suite because we don't have an XODR file with that kind of curve in it. It would be great to add the XODR file you're using to our test suite (assuming that's OK with you and the licensing allows it) to help detect future bugs before they cause you issues.

@Eric-Vin Eric-Vin added the type: bug Something isn't working label Oct 3, 2023
@nasy960
Copy link
Author

nasy960 commented Oct 4, 2023

test.zip

This is the file I used for test.

Do I just need to provide the file I use?

@Eric-Vin
Copy link
Collaborator

Eric-Vin commented Oct 4, 2023

This is great, thanks so much! We'll go ahead and patch this bug.

@Eric-Vin Eric-Vin linked a pull request Oct 4, 2023 that will close this issue
@Eric-Vin Eric-Vin linked a pull request Jul 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants