Skip to content
This repository has been archived by the owner on Nov 13, 2020. It is now read-only.

Enable compatibility with redux-observable@1.x, redux@4.x and rxjs@6.x #37

Conversation

jdachtera
Copy link

Hi @BerkeleyTrue,

This pr enables compatibility with redux-observable@1.x, redux@4.x and rxjs@6.x. (without the need for the rxjs5 compat layer).

Let me know if you need anything to get this merged.

Cheers,
Jascha

@coveralls
Copy link

coveralls commented Nov 23, 2018

Coverage Status

Coverage increased (+0.08%) to 91.429% when pulling c5ec31e on jdachtera:feature/rxjs6+redux-observable1.0 into af034a4 on BerkeleyTrue:master.

@jdachtera
Copy link
Author

@BerkeleyTrue, any chance to get this merged?

@BentoumiTech
Copy link

BentoumiTech commented Dec 6, 2018

@jdachtera Probably some changes would be also needed in the docs/api/README.md as createEpicMiddleware signature changed.

@jdachtera
Copy link
Author

@Neophy7e, thanks! I'll add that as soon as possible.

@jdachtera
Copy link
Author

@NeoPhy7e, @BerkeleyTrue, added the the documentation changes.
Let me know what you think!

@BentoumiTech
Copy link

@jdachtera @BerkeleyTrue I don't know if you were aware but there is currently two PR's in the redux-observable repo that aims to implement SSR directly in the library. Maybe your experience redux-observable and SSR could help out there.

@jdachtera
Copy link
Author

@Neophy7e thanks for pointing this out. My impression of these discussions is that it doesn't seem to be easy to align on the technical implementation. Maybe then it's better to keep it as a separate library for now.

Also as a builtin feature it might increase the bundle size on the client side event though it would only be needed on the server.

Since there has been no activity by the maintainer I've published this under a new namespace for now so everyone can easily use it:
https://www.npmjs.com/package/@jdachtera/react-redux-epic

Cheers!

@BentoumiTech
Copy link

@jdachtera Thank you for making it available through npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants