Fix possible NullPointerException trying to draw tooltip icons #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Show Off with an enchanted book, holding shift to show the tooltip icons (or having them set to always draw) will crash the game on mouse-over.
This comes back to the general issue of
enchantedItemStack
not always being set andcachedTooltipIcons
will returnnull
, thus producing a NPE.Since this general issue is hard to fix, I retorted to the simple fix of skipping the whole method.
I should also say that since
cachedTooltipIcons
is aWeakHashMap
,get
can always returnnull
, so this might fix some crashes in low memory situations as well.