Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue: some vehicles mislabeled #23

Closed
Luigimeansme opened this issue Nov 19, 2021 · 20 comments · Fixed by #87
Closed

Minor issue: some vehicles mislabeled #23

Luigimeansme opened this issue Nov 19, 2021 · 20 comments · Fixed by #87
Labels
enhancement New feature or request

Comments

@Luigimeansme
Copy link
Contributor

Luigimeansme commented Nov 19, 2021

Looking at the list of vehicles, I'm seeing that Cragger's ship is out of order in organization. It's showing that Swamp Skimmer (the default) is one of the rebuilds and Cragger's Fireship (a rebuild) is the default. Some other typos include:
"Cloud Cukko Car" instead of "Cloud Cuckoo Car"
"Gyro Sphere" instead of "Gyrosphere"
"BIONIC STEED" in all caps
"The Jokers Chopper" instead of "The Joker's Chopper"
"K9" instead of "K-9"
These are incredibly minor, just thought I'd point it out anyway

@Berny23
Copy link
Owner

Berny23 commented Nov 19, 2021

Thanks for pointing that out.
I will fix it soon in both this repository and my fork of node-ld (the origin of the list).

@Berny23 Berny23 added the enhancement New feature or request label Nov 19, 2021
@Luigimeansme
Copy link
Contributor Author

@Berny23 Names have all been updated, but the app still claims Cragger's Swamp Skimmer is the second form, not the first form, even after deleting and creating a new one

@Berny23
Copy link
Owner

Berny23 commented Nov 21, 2021

Then, the IDs got mixed up.

Does the game spawn Cragger's Fireship if you select Swamp Skimmer?

@Luigimeansme
Copy link
Contributor Author

Luigimeansme commented Nov 21, 2021

Then, the IDs got mixed up.

Does the game spawn Cragger's Fireship if you select Swamp Skimmer?

Yes it does.
EDIT: Actually, selecting Swamp Skimmer on the list summons in the Croc Command Sub, and selecting the sub summons in the Fireship

Berny23 added a commit that referenced this issue Nov 21, 2021
@Berny23
Copy link
Owner

Berny23 commented Nov 21, 2021

Please try it with the new update.

@Luigimeansme
Copy link
Contributor Author

Please try it with the new update.

Almost. Swamp Skimmer now summons in Fireship, Fireship now summons in Sub, Sub now summons in Skimmer

Berny23 added a commit that referenced this issue Nov 21, 2021
@Berny23
Copy link
Owner

Berny23 commented Nov 21, 2021

Ok, now it should work.

@Luigimeansme
Copy link
Contributor Author

That fixed it, thank you! If I notice anything else wrong with vehicle IDs, I'll post it here

@Luigimeansme
Copy link
Contributor Author

@Berny23 found another vehicle issue. When upgrading Lloyd's Golden Dragon to third form and saving it, the emulator just marks the square as "Unknown." It summons in just fine, but it looks like the emulator doesn't have a label assigned to the Mega Flight Dragon's ID.

@Berny23
Copy link
Owner

Berny23 commented Dec 13, 2021

@Luigimeansme Please tell me what ID number the "Unknown" vehicle has. You can find it by right-clicking the square -> Inspect (element) -> look for "data-id=" in the selected line (not data-uid).

@Luigimeansme
Copy link
Contributor Author

@Luigimeansme Please tell me what ID number the "Unknown" vehicle has. You can find it by right-clicking the square -> Inspect (element) -> look for "data-id=" in the selected line (not data-uid).

If I am looking in the right area, it says the ID is 1144. I also went ahead and tested creating a separate Mega Flight Dragon square and summoning it in, and it just gave the "An update is required to use this content" message. The ID for this one says 1134, so it looks like it's just a small typo

@Luigimeansme
Copy link
Contributor Author

@Berny23 Realized I forgot to ping you again and it's a closed issue so you might not've seen it. My previous post has the IDs needed

Berny23 added a commit that referenced this issue Dec 16, 2021
@Berny23
Copy link
Owner

Berny23 commented Dec 16, 2021

@Luigimeansme Ok, for some reason the third form of the dragon has the ID 1144, but the other two are 1132 and 1133.
I switched the labels, please update the emulator.

@Luigimeansme
Copy link
Contributor Author

@Berny23 That fixed it, thanks! I'm working on a 100% run rn so if I notice any other busted IDs, I'll let you know

@Berny23
Copy link
Owner

Berny23 commented Dec 16, 2021

Nice!
The whole reason why I created this emulator, was because I also want to 100% it one day.

@Luigimeansme
Copy link
Contributor Author

@Berny23 Do you possibly have a Discord account? It would make things easier to point out rather than constantly mucking up the issues page here.

@Luigimeansme
Copy link
Contributor Author

@Berny23 Found another one. KITT Jet and Goliath Armored Semi are backwards, upgrading to tier 3 will label it as Goliath Armored Semi and upgrading to tier 2 will label it as KITT Jet

Berny23 added a commit that referenced this issue Jan 23, 2022
…d and improve troubleshooting sections, fix mismatched IDs #23
@Luigimeansme
Copy link
Contributor Author

@Berny23 I found one more mislabled vehicle. The DeLorean builds 2 and 3 are swapped, so build 2 (Electric Time Machine) is labeled as the Ultra Time Machine, and build 3 (Ultra Time Machine) is labeled as the Electric Time Machine

@Berny23
Copy link
Owner

Berny23 commented Aug 4, 2022

Fixed it. f545175

@Luigimeansme
Copy link
Contributor Author

@Berny23 Found another one: Sensei Wu's Flying White Dragon is mislabeled as "Flight White Dragon." Sorry if this is getting annoying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants