Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema check #100

Merged
merged 1 commit into from
Dec 21, 2022
Merged

JSON schema check #100

merged 1 commit into from
Dec 21, 2022

Conversation

VladimirKuletski
Copy link
Contributor

Used one of GH Actions to add schema validation for charactermap, tokenmap files.
Intent is to avoid any errors, typos in such big JSON files. So each PR and commit should have smoke check statuses.

Built schemas with constructors and adjusted them manually.
Feel free to reorganize directory structure your way if needed.

Last step to close #98

P.S. Probably node tests is the better place for these checks, but it's easier for me to implement it this way.

P.S.2 Will keep an eye on Action. It uses several deprecated commands. Will migrate to something else if it's not maintained properly.

@Berny23
Copy link
Owner

Berny23 commented Dec 21, 2022

Thank you for the work!

@Berny23 Berny23 merged commit 06c077f into Berny23:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json schema validation
2 participants