Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Update integration with Lunary #2244

Merged
merged 16 commits into from Mar 30, 2024
Merged

Conversation

vincelwt
Copy link
Contributor

Hi guys,
This update the integration with Lunary (prev. LLMonitor) to use our official package which improves the reliability of the tracking and enables support for tracing when observing full agents.
Tested and everything works with completions.

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 4:22am
litellm-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 4:22am

@krrishdholakia krrishdholakia marked this pull request as draft February 29, 2024 20:07
@vincelwt
Copy link
Contributor Author

vincelwt commented Mar 1, 2024

Hi @krrishdholakia should be all good now :) Thanks!

litellm/utils.py Outdated Show resolved Hide resolved
@vincelwt
Copy link
Contributor Author

Hey @krrishdholakia - I've resolved the latest conflicts. Anything else to do to get this merged? Thanks

@krrishdholakia
Copy link
Contributor

@vincelwt looks like there's some unresolved merge conflicts. can you fix them and bump me? i'll merge it in

Screenshot 2024-03-16 at 7 15 03 PM

@krrishdholakia
Copy link
Contributor

bump @vincelwt

@vincelwt
Copy link
Contributor Author

Done @krrishdholakia

image

@ishaan-jaff
Copy link
Contributor

@vincelwt did you test this to verify the cals get logged from litellm to lunary ? Can you send us a a screenshot of a working completion & embedding call logged

@vincelwt
Copy link
Contributor Author

vincelwt commented Mar 21, 2024

Yes guys as I said in the PR message everything is tested and works. Lunary doesn't support embeddings so it ignores those at the backend level for now. @ishaan-jaff

image

@vincelwt
Copy link
Contributor Author

I've resolved the conflicts one more time but it'd be nice if you could merge this soon as there are more conflicts every time

@demux79
Copy link

demux79 commented Mar 28, 2024

Would be great to get this merged 🙏

@richloh
Copy link

richloh commented Mar 28, 2024

Any updates on this? We really love litellm, and would be great to have this PR merged so the various bugs we face with litellm related to lunary are addressed. Thanks!

@krrishdholakia krrishdholakia merged commit dfd20cb into BerriAI:main Mar 30, 2024
1 check passed
@krrishdholakia
Copy link
Contributor

LGTM! Just merged

@Caixiaopig
Copy link
Contributor

When starting litellm using the Docker image, it is not possible to access Lunary because the Python library for Lunary is not installed in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants